fix(codeSign) shell command built from environment values

[odaysec]

headlamp/app/mac/scripts/codeSign.js

Line 2 in 5a33401

const { execSync } = require('child_process');

headlamp/app/mac/scripts/codeSign.js

Lines 17 to 18 in 5a33401

	execSync(
	`codesign -s ${teamID} --deep --force --options runtime --entitlements ${entitlementsPath} ${config.app}`

Fix the issue will replace the use of execSync with execFileSync, which allows us to pass the command and its arguments separately. This approach avoids shell interpretation of the arguments, mitigating the risk of command injection. Specifically:

1. The codesign command will be passed as the first argument to execFileSync.
2. The dynamic components (teamID, entitlementsPath, and config.app) will be passed as separate arguments in an array.
3. This change ensures that special characters in the inputs are treated as literal values and not interpreted by the shell.

[k8s-ci-robot]

Welcome @odaysec!

It looks like this is your first PR to kubernetes-sigs/headlamp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/headlamp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[illume]

🎉🎈 thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: illume, odaysec

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [illume]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment