Add a way to get the resource kind from its resource classAdd resource kind method#3351
Add a way to get the resource kind from its resource classAdd resource kind method#3351kallal79 wants to merge 30 commits intokubernetes-sigs:mainfrom kallal79:add-resource-kind-method
Conversation
- Added 40px margin to bottom of sidebar toggle button - Prevents button from being hidden by auto-hiding taskbar - Added comprehensive test suite for button accessibility - Includes responsive design tests - Maintains cross-platform compatibility Fixes #1287
Fix/sidebar toggle button position
…ddleware function
|
Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 7908837174 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
I don't actually think this PR is necessary since every KubeObject already exposes its kind as a static property. Closing for now |
|
Gotcha.
…On Tue, 10 Jun, 2025, 19:01 evangelos, ***@***.***> wrote:
*skoeva* left a comment (kubernetes-sigs/headlamp#3351)
<#3351 (comment)>
I don't actually think this PR is necessary since every KubeObject already
exposes its kind as a static property. Closing for now
—
Reply to this email directly, view it on GitHub
<#3351 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BLR2IIJIT4Z63NIN7YSJXQT3C3MZPAVCNFSM6AAAAAB53C2A4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSNJZGI3TMOJRHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This PR adds a static getKind() method to the KubeObject class to allow accessing the resource kind from resource classes without instantiation.
Fixes the issue where there was no consistent way to get the kind from a resource class.
Changes: