Skip to content

Add a way to get the resource kind from its resource classAdd resource kind method#3351

Closed
kallal79 wants to merge 30 commits intokubernetes-sigs:mainfrom
kallal79:add-resource-kind-method
Closed

Add a way to get the resource kind from its resource classAdd resource kind method#3351
kallal79 wants to merge 30 commits intokubernetes-sigs:mainfrom
kallal79:add-resource-kind-method

Conversation

@kallal79
Copy link
Copy Markdown

This PR adds a static getKind() method to the KubeObject class to allow accessing the resource kind from resource classes without instantiation.

Fixes the issue where there was no consistent way to get the kind from a resource class.

Changes:

  • Added static getKind() method to KubeObject class ..
  • Added tests to verify the method works correctly...

kallal79 and others added 30 commits May 16, 2025 11:14
- Added 40px margin to bottom of sidebar toggle button
- Prevents button from being hidden by auto-hiding taskbar
- Added comprehensive test suite for button accessibility
- Includes responsive design tests
- Maintains cross-platform compatibility

Fixes #1287
#2554-Kallal-Columns filter state preservation #3258
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

  • 7014f44 fix: Move sidebar toggle button up to avoid taskbar overlap
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label May 25, 2025
@linux-foundation-easycla
Copy link
Copy Markdown

CLA Missing ID CLA Not Signed

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 7908837174
Once this PR has been reviewed and has the lgtm label, please assign illume for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 25, 2025
@k8s-ci-robot k8s-ci-robot requested review from illume and skoeva May 25, 2025 00:03
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 25, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 2, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@skoeva
Copy link
Copy Markdown
Contributor

skoeva commented Jun 10, 2025

I don't actually think this PR is necessary since every KubeObject already exposes its kind as a static property. Closing for now

@skoeva skoeva closed this Jun 10, 2025
@kallal79
Copy link
Copy Markdown
Author

kallal79 commented Jun 10, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

4 participants