Skip to content

Remove dependency on enzyme #1668 #3350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

7908837174
Copy link

Syntax error in the OIDC Token Refresh Middleware function in backend/cmd/headlamp.go
The function incorrectly called next.ServeHTTP(w, r)eHTTP(w, r) instead of just next.ServeHTTP(w, r)
This typo caused the request to fail after token refresh..

Fixed the typo in the OIDCTokenRefreshMiddleware function:
Changed: next.ServeHTTP(w, r)eHTTP(w, r)
To: next.ServeHTTP(w, r) ......

7908837174 and others added 29 commits May 16, 2025 11:14
- Added 40px margin to bottom of sidebar toggle button
- Prevents button from being hidden by auto-hiding taskbar
- Added comprehensive test suite for button accessibility
- Includes responsive design tests
- Maintains cross-platform compatibility

Fixes kubernetes-sigs#1287
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label May 24, 2025
@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

  • 7014f44 fix: Move sidebar toggle button up to avoid taskbar overlap

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

CLA Not Signed

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 7908837174
Once this PR has been reviewed and has the lgtm label, please assign illume for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 24, 2025
@7908837174
Copy link
Author

7908837174 commented May 24, 2025 via email

@illume
Copy link
Contributor

illume commented May 25, 2025

Thank you for this.

It looks like you're using a new branch now.

However your main branch on your repo needs to be reset, then the branch should include only the commit(s) you want to include in the PR.

You can reset the main branch like so:

# back up your old main branch and then remove the main branch
git checkout main
git checkout -b main-bak

git branch -D main

# add an upstream remote if you don't already have one.
git remote -v
git remote add upstream [email protected]:kubernetes-sigs/headlamp.git
git fetch upstream --all

Afterwards you should be able to create new branches with all these other commits in there.

Then later to sync your new main branch you can do this:

git checkout main
git pull upstream main

@7908837174
Copy link
Author

7908837174 commented May 25, 2025 via email

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 2, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@7908837174
Copy link
Author

7908837174 commented Jun 2, 2025 via email

Copy link
Author

@7908837174 7908837174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/KALLAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants