-
Notifications
You must be signed in to change notification settings - Fork 362
Remove dependency on enzyme #1668 #3350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove dependency on enzyme #1668 #3350
Conversation
- Added 40px margin to bottom of sidebar toggle button - Prevents button from being hidden by auto-hiding taskbar - Added comprehensive test suite for button accessibility - Includes responsive design tests - Maintains cross-platform compatibility Fixes kubernetes-sigs#1287
Fix/sidebar toggle button position
kubernetes-sigs#2554-Kallal-Columns filter state preservation kubernetes-sigs#3258
…ddleware function
Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 7908837174 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixed!
…On Sun, 25 May, 2025, 04:35 Kubernetes Prow Robot, ***@***.***> wrote:
*k8s-ci-robot* left a comment (kubernetes-sigs/headlamp#3350)
<#3350 (comment)>
[APPROVALNOTIFIER] This PR is *NOT APPROVED*
This pull-request has been approved by: *7908837174
<#3350#>*
*Once this PR has been reviewed and has the lgtm label*, please assign
illume <https://github.com/illume> for approval. For more information see the
Code Review Process
<https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process>
.
The full list of commands accepted by this bot can be found here
<https://go.k8s.io/bot-commands?repo=kubernetes-sigs%2Fheadlamp>.
Needs approval from an approver in each of these files:
- *OWNERS
<https://github.com/kubernetes-sigs/headlamp/blob/main/OWNERS>*
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
—
Reply to this email directly, view it on GitHub
<#3350 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BLR2IINZLVOXRPL6D7RQMYD3AD3J5AVCNFSM6AAAAAB53BM6UCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMBXGMZDIMZVGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thank you for this. It looks like you're using a new branch now. However your main branch on your repo needs to be reset, then the branch should include only the commit(s) you want to include in the PR. You can reset the main branch like so:
Afterwards you should be able to create new branches with all these other commits in there. Then later to sync your new main branch you can do this:
|
Thank you, I will do that.
…On Sun, 25 May, 2025, 10:40 René Dudfield, ***@***.***> wrote:
*illume* left a comment (kubernetes-sigs/headlamp#3350)
<#3350 (comment)>
Thank you for this.
It looks like you're using a new branch now.
However your main branch on your repo needs to be reset, then the branch
should include only the commit(s) you want to include in the PR.
You can reset the main branch like so:
git branch -D main
git fetch --all
Afterwards you should be able to create new branches with all these other
commits in there.
—
Reply to this email directly, view it on GitHub
<#3350 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BLR2IIPL7EBYQRCU3QMYQML3AFGFJAVCNFSM6AAAAAB53BM6UCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMBXGYYTINRRGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Done.
…On Mon, 2 Jun, 2025, 19:27 Kubernetes Prow Robot, ***@***.***> wrote:
*k8s-ci-robot* left a comment (kubernetes-sigs/headlamp#3350)
<#3350 (comment)>
PR needs rebase.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes-sigs/prow
<https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:>
repository.
—
Reply to this email directly, view it on GitHub
<#3350 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BLR2IIKVBY3ZCWTRTS6LR3L3BRJ3JAVCNFSM6AAAAAB53BM6UCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMZQHA3DCNZTGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/KALLAL
Syntax error in the OIDC Token Refresh Middleware function in backend/cmd/headlamp.go
The function incorrectly called next.ServeHTTP(w, r)eHTTP(w, r) instead of just next.ServeHTTP(w, r)
This typo caused the request to fail after token refresh..
Fixed the typo in the OIDCTokenRefreshMiddleware function:
Changed: next.ServeHTTP(w, r)eHTTP(w, r)
To: next.ServeHTTP(w, r) ......