plugin bundling scripts need to check checksum when downloading #2539Add checksum verification

[7908837174]

Related files:

build-manifest.json
app-build-manifest.json
app/scripts/setup-plugins.js
container/fetch-plugins.sh

[linux-foundation-easycla]

• ❌ - login: @7908837174 / name: Kallal Mukherjee . The commit (77491c5, 9a3ca41, e371b8f, 1f931c8, 25e0faa, 71893f3, 02a2917, fae17ae, 06b8154, 0ef34ee, c58ee6e, f3dfe4c, 615da27, f9269cc, 1106641, 96ae21f, 7014f44, c574934, a0ff601, 7614f43, d3ccd64, 4709f32, f4377d6, eaf145b, 67da886, 221ee7c, be1ae59, 94614a6, fd5cb62) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.
• ❌ - login: @superman32432432 . The commit (2e1ecb8) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 7908837174
Once this PR has been reviewed and has the lgtm label, please assign illume for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

• 7014f44 fix: Move sidebar toggle button up to avoid taskbar overlap
• 2e1ecb8 Fix View crashed Pod logs (previous logs) #3225: Enable viewing previous logs for crashed containers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[illume]

Thanks @7908837174

It seems there's a bunch of unrelated commits in here.

Here's how you can fix it:

• make a new branch with all your main things on it (so you have a backup)
• sync your main branch to the headlamp main branch (they should be the same)
• create a new branch with your commit on there (you can use git cherry-pick to bring your commit in)
• create a new PR with your new branch

Basically,

• always work on a new branch not on your forks main branch. This lets you create new PRs easily with those branches.
• always keep your forks main branch in sync with the headlamp main branch

---

For the CLA check failing: If you click here you will see instructions on what to do: https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/20677499/220546758/3336/#/?version=2

Your email address example . com is not a valid domain name. So that's probably why the CLA tool won't work... it needs a real email address. The github privacy preserving one works.

---

Your main branch on your repo needs to be reset, then the branch should include only the commit(s) you want to include in the PR.

You can reset the main branch like so:

# back up your old main branch and then remove the main branch
git checkout main
git checkout -b main-bak

git branch -D main

# add an upstream remote if you don't already have one.
git remote -v
git remote add upstream [email protected]:kubernetes-sigs/headlamp.git
git fetch upstream --all

Afterwards you should be able to create new branches with all these other commits in there.

Then later to sync your new main branch you can do this:

git checkout main
git pull upstream main

[7908837174]

Thanks for the tip!

…

On Fri, 23 May, 2025, 13:44 René Dudfield, ***@***.***> wrote: *illume* left a comment (kubernetes-sigs/headlamp#3336) <#3336 (comment)> Thanks @7908837174 <https://github.com/7908837174> It seems there's a bunch of unrelated commits in here. Here's how you can fix it: - make a new branch with all your main things on it (so you have a backup) - sync your main branch to the headlamp main branch - create a new branch with your commit on there (you can use git cherry-pick to bring your commit in) - create a new PR with your new branch — Reply to this email directly, view it on GitHub <#3336 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BLR2IIOO7W3S2OZJQFO7EUL273KHJAVCNFSM6AAAAAB5XTZBQCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMBTGY2DIMJRHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[illume]

@7908837174 Let me know if you need any help? Feel free to dm me on the k8s slack if you want to chat to try and fix it together.

But I think the instructions above should be comprehensive enough to fix things.

[7908837174]

Thanks for the tip!

…

On Mon, 26 May, 2025, 23:59 René Dudfield, ***@***.***> wrote: *illume* left a comment (kubernetes-sigs/headlamp#3336) <#3336 (comment)> @7908837174 <https://github.com/7908837174> Let me know if you need any help? Feel free to dm me on the k8s slack if you want to chat to try and fix it together. But I think the instructions above should be comprehensive enough to fix things. — Reply to this email directly, view it on GitHub <#3336 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BLR2IIJYB5N2NH7QK7PNWF33ANMQDAVCNFSM6AAAAAB5XTZBQCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMJQGQYTCNBQGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>