-
Notifications
You must be signed in to change notification settings - Fork 358
frontend: add EmptyContent Storybook stories #3323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
frontend: add EmptyContent Storybook stories #3323
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ANIRUDH-SJ The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hey @illume can u please review this ?? |
Hey, your test are failing for Command Suggestions (for linting):
For the |
Ok i will submit a new PR correcting this. Thanks for your feedback |
There is no need for a new PR, you can just correct the test and |
Alright will do this sir!! |
a53c00c
to
2d8bf92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the frontend test is still failing, make sure to rebase one more time in case it's related to issues on main. If that doesn't fix it, run make frontend-test
locally again and update any failing snapshots in your commits
68e7376
to
f1e9c6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the tests are failing.
Can you please have a look at updating some of the commit messages?
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Added comprehensive Storybook stories for the EmptyContent component.