Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated configurations and ensure the tutorial runs smoothly #136

Merged
merged 3 commits into from
Dec 30, 2024
Merged

Remove outdated configurations and ensure the tutorial runs smoothly #136

merged 3 commits into from
Dec 30, 2024

Conversation

Jeffwan
Copy link
Contributor

@Jeffwan Jeffwan commented Dec 29, 2024

address #135

Remove outdated configurations and ensure the tutorial runs smoothly

@k8s-ci-robot k8s-ci-robot requested a review from ahg-g December 29, 2024 07:22
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 29, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 29, 2024
@ahg-g
Copy link
Contributor

ahg-g commented Dec 30, 2024 •
edited
Loading

Thanks @Jeffwan ; does this address all the issues in #135? Specifically, point 4 perhaps needs docs updates?

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit eefcaf7 into kubernetes-sigs:main Dec 30, 2024
4 checks passed
@Jeffwan
Copy link
Contributor Author

Jeffwan commented Dec 31, 2024 •
edited
Loading

@ahg-g yes, I missed the doc update. @yankay addresses the missing piece in #139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g Awaiting requested review from ahg-g

@liu-cong liu-cong Awaiting requested review from liu-cong

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jeffwan @k8s-ci-robot @ahg-g