-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 crd: Respect multiline comments at godocs #870
🐛 crd: Respect multiline comments at godocs #870
Conversation
68cbc38
to
a8aa71c
Compare
/cc @varshaprasad96 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good to me, but it would break a lot of existing docs. @qinqon Some of the integration tests are failing due to formating changes, could you please fix them? (https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_controller-tools/870/pull-controller-tools-test-master/1737421873815228416#)
cc: @alvaroaleman any thoughts on this? Making this change optional may be an overkill. Having this introduced in a new release is still fine?
Ok, let me fix stuff. |
a8aa71c
to
3dee960
Compare
43f22dd
to
e6e1a30
Compare
Sometimes at type has examples about how to use it embedding something like a yaml on it, yamls should not be truncated and they are white space sensitive. This change keep the new lines and also remove the white space trimming only on /* comments. Signed-off-by: Enrique Llorente <[email protected]>
e6e1a30
to
7488021
Compare
@varshaprasad96 @alvaroaleman test fixed, I have regenerate all the testing CRDs impacted so you can check how "description" field looks now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, qinqon, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change has an influence on the generated descriptions, most likely because of kubernetes-sigs/controller-tools#870
Sometimes at type has examples about how to use it embedding something like a yaml on it, yamls should not be truncated and they are white space sensitive. This change keep the new lines and also remove the white space trimming only on /* comments.
Golang struct example with problematic comment.
Part of the probem was introduced at #517