-
Notifications
You must be signed in to change notification settings - Fork 444
Tests: speed up ci #1239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Tests: speed up ci #1239
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ls-2018 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @ls-2018! |
Hi @ls-2018. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: acejilam <[email protected]>
/ok-to-test |
@ls-2018: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -25,6 +25,8 @@ jobs: | |||
uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # tag=v5.5.0 | |||
with: | |||
go-version: ${{ steps.vars.outputs.go_version }} | |||
check-latest: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that this will actually slow down the CI by looking for newer go versions, rather than pinning to the version we have defined. I'm not sure we would want to be constantly pulling newer go versions anyway, typically we pin to a known working version and then update periodically from there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree
No description provided.