[release-0.22] ✨ envtest: respect pre-configured binary paths in ControlPlane #3377
+96
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where Environment.Start() would ignore pre-configured binary paths (APIServer.Path, Etcd.Path, KubectlPath) set in ControlPlane when DownloadBinaryAssets is false. Changes: - Extract path configuration logic into configureBinaryPaths() method for better testability and separation of concerns - Only auto-configure binary paths when they are empty (not pre-set) - When DownloadBinaryAssets is true, downloaded paths are still used (preserving existing behavior) - Update ControlPlane field documentation to clarify path behavior - Add tests in envtest_test.go to verify path handling logic
k8s-ci-robot
added
the
cncf-cla: yes
alvaroaleman
approved these changes
Nov 2, 2025
k8s-ci-robot
added
size/L
|
LGTM label has been added. Git tree hash: c4ff514172fd6412fc063c7ea5959fc2550c25ed
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, k8s-infra-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #3372
/assign alvaroaleman