-
Notifications
You must be signed in to change notification settings - Fork 1.2k
✨ cache: Allow fine-granular SyncPeriod configuration #3376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ cache: Allow fine-granular SyncPeriod configuration #3376
Conversation
|
/assign @alvaroaleman /hold |
|
|
||
| // SyncPeriod determines the minimum frequency at which watched resources are | ||
| // reconciled. | ||
| SyncPeriod *time.Duration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we copy the docs we have for this in opts to these two new places as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't sure, but I guess why not :)
(done)
Signed-off-by: Stefan Büringer [email protected]
6699bce to
88b888d
Compare
|
LGTM label has been added. Git tree hash: cfc7b1628598155ca5461874aeb85e68881405e4
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
|
/cherry-pick release-0.22 |
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@sbueringer: new pull request created: #3378 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Stefan Büringer [email protected]
Fixes #3362