Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Return error when object limit exceeded for cached list calls #3045

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🐛 Return error when object limit exceeded for cached list calls #3045

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions pkg/cache/internal/cache_reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,15 +139,17 @@ func (c *CacheReader) List(_ context.Context, out client.ObjectList, opts ...cli
labelSel = listOpts.LabelSelector
}

// Since the cache does not implement strongly consistent paginated list
// calls, if the Limit option is set and the number of items listed exceeds
// this limit, there is no way for the caller to get a complete list of
// objects, so return an error here to notify the caller.
limitSet := listOpts.Limit > 0
if limitSet && int64(len(objs)) > listOpts.Limit {
return fmt.Errorf("object limit exceeded but paginated list is not supported by the cache")
}

runtimeObjs := make([]runtime.Object, 0, len(objs))
for _, item := range objs {
// if the Limit option is set and the number of items
// listed exceeds this limit, then stop reading.
if limitSet && int64(len(runtimeObjs)) >= listOpts.Limit {
break
}
obj, isObj := item.(runtime.Object)
if !isObj {
return fmt.Errorf("cache contained %T, which is not an Object", item)
Expand Down
Loading