Skip to content

🌱 Skipping test that is failing because of infra issues #12496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adilGhaffarDev
Copy link
Contributor

@adilGhaffarDev adilGhaffarDev commented Jul 15, 2025

What this PR does / why we need it:
Skipping Test:
[Feature:IPv6DualStack] Granular Checks: Services Secondary IP Family [LinuxOnly] should function for service endpoints using hostNetwork

This test is being skipped because it consistently fails on EKS clusters.
It also fails in Kind when running on EKS. However, when running on GKE, the same test passes in both Kind and CAPI.

Since we cannot move CAPI jobs to GKE at this time, we are skipping the test in CAPI e2e for now.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Jul 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

This PR is currently missing an area label, which is used to identify the modified component when generating release notes.

Area labels can be added by org members by writing /area ${COMPONENT} in a comment

Please see the labels list for possible areas.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested a review from elmiko July 15, 2025 20:00
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 15, 2025
@k8s-ci-robot k8s-ci-robot requested a review from sivchari July 15, 2025 20:00
@adilGhaffarDev
Copy link
Contributor Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@adilGhaffarDev: The following commands are available to trigger required jobs:

/test pull-cluster-api-build-main
/test pull-cluster-api-e2e-blocking-main
/test pull-cluster-api-e2e-conformance-ci-latest-main
/test pull-cluster-api-e2e-conformance-main
/test pull-cluster-api-e2e-latestk8s-main
/test pull-cluster-api-e2e-main
/test pull-cluster-api-e2e-main-gke
/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-e2e-upgrade-1-33-1-34-main
/test pull-cluster-api-test-main
/test pull-cluster-api-test-mink8s-main
/test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

/test pull-cluster-api-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-apidiff-main
pull-cluster-api-build-main
pull-cluster-api-e2e-blocking-main
pull-cluster-api-test-main
pull-cluster-api-verify-main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adilGhaffarDev
Copy link
Contributor Author

/test pull-cluster-api-e2e-main-gke

@adilGhaffarDev
Copy link
Contributor Author

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2025
@sbueringer
Copy link
Member

/test capi-kubernetes-kind-network-ipv6

@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-main-gke

@adilGhaffarDev
Copy link
Contributor Author

We also need to clone the kind repo in the test YAML, I will open the PR to do that.

@adilGhaffarDev
Copy link
Contributor Author

We also need to clone the kind repo in the test YAML, I will open the PR to do that.

No, I think this line is not needed in the yaml:
https://github.com/kubernetes/test-infra/blob/399bdabc403fef00afc55f51938be3dba82c4eed/config/jobs/kubernetes-sigs/cluster-api/cluster-api-main-presubmits.yaml#L559

@adilGhaffarDev
Copy link
Contributor Author

@sbueringer , please check: kubernetes/test-infra#35239

@adilGhaffarDev
Copy link
Contributor Author

/test pull-cluster-api-e2e-main-gke

@adilGhaffarDev
Copy link
Contributor Author

/test capi-kubernetes-kind-network-ipv6

@sbueringer
Copy link
Member

Yeah, that is what I expected, now the job is running CAPI tests instead of kind tests

@sbueringer
Copy link
Member

sbueringer commented Jul 29, 2025

@adilGhaffarDev Can you try to set workdir: true for the kind repo?

(xref: https://github.com/kubernetes-sigs/prow/blob/0ee99b9ee1bd56595519879d1e01224e0d74eceb/pkg/apis/prowjobs/v1/types.go#L1156)

Like this

    extra_refs:
    - org: kubernetes-sigs
      repo: kind
      base_ref: main
      path_alias: sigs.k8s.io/kind
      workdir: true

@adilGhaffarDev
Copy link
Contributor Author

kubernetes/test-infra#35240

@adilGhaffarDev Can you try to set workdir: true for the kind repo?

(xref: https://github.com/kubernetes-sigs/prow/blob/0ee99b9ee1bd56595519879d1e01224e0d74eceb/pkg/apis/prowjobs/v1/types.go#L1156)

Like this

    extra_refs:
    - org: kubernetes-sigs
      repo: kind
      base_ref: main
      path_alias: sigs.k8s.io/kind
      workdir: true

I think repo: kubernetes should be the work directory, test we are duplicating is this kubernetes-kind-network-ipv6 and it is running kind test but in k8s repo.

@sbueringer
Copy link
Member

Okay looked up the job. Agree. There should be no need to even clone the kind repo?

@adilGhaffarDev
Copy link
Contributor Author

Okay looked up the job. Agree. There should be no need to even clone the kind repo?

agree, I have updated the PR: kubernetes/test-infra#35240

@adilGhaffarDev
Copy link
Contributor Author

/test capi-kubernetes-kind-network-ipv6

@sbueringer
Copy link
Member

sbueringer commented Jul 30, 2025

Hm, two tests cases are failing. Are we sure we are running the same tests? I'm missing the "[Feature:IPv6DualStack]" prefix

@adilGhaffarDev
Copy link
Contributor Author

Hm, two tests cases are failing. Are we sure we are running the same tests? I'm missing the "[Feature:IPv6DualStack]" prefix

failures are similar, both fail when handle large requests: udp(hostNetwork) with ipv6:

In CAPI test failure is at following line:
In [It] at: k8s.io/kubernetes/test/e2e/network/dual_stack.go:674 @ 07/31/25 05:34:33.536

And in case of kind it fails at:
In [It] at: k8s.io/kubernetes/test/e2e/network/networking.go:541 @ 07/30/25 18:20:21.834

I think if we change IP_FAMILY to dualstack we will see failure on same line. But current failure also proves the point.

@sbueringer
Copy link
Member

I mean it seems like we are not running the same test? I thought in testgrid I saw the exact same test case/name

@adilGhaffarDev
Copy link
Contributor Author

adilGhaffarDev commented Jul 31, 2025

I mean it seems like we are not running the same test? I thought in testgrid I saw the exact same test case/name

We copied the PR job and it seems PR job is not running exact same test.
Now I have changed the some test parameters to make same as this periodic: https://testgrid.k8s.io/sig-network-kind#sig-network-kind,%20dual,%20master , Prow: https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/ci-kubernetes-kind-network-dual/1950826630913986560
This has the test that CAPI is running,
Sorry I thought that PR and periodic jobs are running same test, it seems like they are not.
Please check: kubernetes/test-infra#35249

@sbueringer
Copy link
Member

No worries, thx!

@sbueringer
Copy link
Member

/test capi-kubernetes-kind-network-dual

@k8s-ci-robot
Copy link
Contributor

@adilGhaffarDev: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
capi-kubernetes-kind-network-ipv6 be07107 link false /test capi-kubernetes-kind-network-ipv6
capi-kubernetes-kind-network-dual be07107 link false /test capi-kubernetes-kind-network-dual

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sbueringer
Copy link
Member

sbueringer commented Jul 31, 2025

Okay. Now we have the exact same error

Given that the error also occurs with kind, I would skip this test in our e2e tests. I think that should be possible via skip in https://github.com/kubernetes-sigs/cluster-api/blob/35c260655f40bf1bebde234e41fb15b36d364550/test/e2e/data/kubetest/dualstack.yaml#L1-L0

I would try to only exactly skip [Feature:IPv6DualStack] Granular Checks: Services Secondary IP Family [LinuxOnly] should function for service endpoints using hostNetwork

@adilGhaffarDev
Copy link
Contributor Author

Okay. Now we have the exact same error

Given that the error also occurs with kind, I would skip this test in our e2e tests. I think that should be possible via skip in https://github.com/kubernetes-sigs/cluster-api/blob/35c260655f40bf1bebde234e41fb15b36d364550/test/e2e/data/kubetest/dualstack.yaml#L1-L0

I would try to only exactly skip [Feature:IPv6DualStack] Granular Checks: Services Secondary IP Family [LinuxOnly] should function for service endpoints using hostNetwork

I can do it.

@sbueringer
Copy link
Member

Sounds good. Thank you!

@adilGhaffarDev
Copy link
Contributor Author

/test pull-cluster-api-e2e-main

@adilGhaffarDev adilGhaffarDev changed the title 🌱 Test PR for testing on GKE cluster 🌱 Skipping test that is failing because of infra issues Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/needs-area PR is missing an area label size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants