✨Propagate the deletion related timeout from MD to old MS when old MS is getting deleted #12144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/L
|
/area machine |
k8s-ci-robot
added
area/machine
sivchari
reviewed
May 3, 2025
internal/controllers/machinedeployment/machinedeployment_rolling.go
Outdated
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_rollout_ondelete.go
Outdated
Show resolved
Hide resolved
internal/controllers/machinedeployment/machinedeployment_sync.go
Outdated
Show resolved
Hide resolved
sivchari
reviewed
May 4, 2025
internal/controllers/machinedeployment/machinedeployment_sync.go
Outdated
Show resolved
Hide resolved
lubronzhan
force-pushed
the
topic/lubron/fix-10753
branch
from
ecc96d3 to
48b83c1
Compare
…is getting deleted Signed-off-by: Lubron Zhan <[email protected]> Co-authored-by: sivchari <[email protected]>
lubronzhan
force-pushed
the
topic/lubron/fix-10753
branch
from
48b83c1 to
2a4ac40
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: f711da8b4d7b4386a9519d3105d95960483ae1ba
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix case 3 in #10753
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes ##10753