[release-1.8] 🌱 Call patchHelper only if necessary when reconciling external refs #11684
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-patch-rec-ext-1.8
branch
from
9c61b04 to
8c6e1b4
Compare
|
/test pull-cluster-api-e2e-release-1-8 |
| UID: cluster.UID, | ||
| } | ||
|
|
||
| if util.HasExactOwnerRef(obj.GetOwnerReferences(), desiredOwnerRef) { |
There was a problem hiding this comment.
Note: this here lacks checking if the uid matches :think:
There was a problem hiding this comment.
(same in machineset controller and propably others)
There was a problem hiding this comment.
Yup. I think you're right. I'll follow-up tomorrow with a PR against main
There was a problem hiding this comment.
Let's merge this PR independent of that. Will open a PR against main in a few minutes and then we can cherry-pick that one into 1.9 + 1.8
|
/lgtm /hold for @chrischdi to take a final look |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: ce2861bf9bc8ea87a58ffc41b73a37aabc3e9e24
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm Fix for above will come from cherry-picking #11688 |
|
/hold cancel Thx folks! |
k8s-ci-robot
removed
the
do-not-merge/hold
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Manual cherry-pick of #11666
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #