Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Remove deprecated flag for old infra machine naming #11679

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Jan 13, 2025

What this PR does / why we need it:

Removes the flag --use-deprecated-infra-machine-naming, which was planned to disappear in CAPI v1.9.

Which issue(s) this PR fixes:
Refs #10576
Refs #11172

/area provider/control-plane-kubeadm
/area machineset

@k8s-ci-robot k8s-ci-robot added area/provider/control-plane-kubeadm Issues or PRs related to KCP area/machineset Issues or PRs related to machinesets cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 13, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 13, 2025
@mboersma
Copy link
Contributor Author

/cc @lentzi90

@k8s-ci-robot k8s-ci-robot requested a review from lentzi90 January 13, 2025 23:24
@mboersma mboersma mentioned this pull request Jan 13, 2025
38 tasks
@k8s-ci-robot
Copy link
Contributor

@mboersma: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 35b6b0c link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lentzi90
Copy link
Contributor

Could we get #11172 merged first?

@adilGhaffarDev
Copy link
Contributor

Could we get #11172 merged first?

/hold
The above PR is required prior to removing this flag.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2025
@sbueringer
Copy link
Member

Could we get #11172 merged first?

Yup, absolutely. I should get around to 11172 soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/machineset Issues or PRs related to machinesets area/provider/control-plane-kubeadm Issues or PRs related to KCP cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants