-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Fix reconcile extensions dashboard #11607
base: main
Are you sure you want to change the base?
🌱 Fix reconcile extensions dashboard #11607
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -18,7 +18,6 @@ | |||
"editable": true, | |||
"fiscalYearStartMonth": 0, | |||
"graphTooltip": 0, | |||
"id": 6, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be kept? (the other dashboards have an id set)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I edited the dashboard in the UX and then saved the json from there, not sure why the ID was dropped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as the dashboard still works on tilt up
I'm fine either way.
In general it would be good if we keep exporting dashboards the same way going forward so we don't go back on forth on things like this (IIRC there are various ways to export or save dashboards in Grafana)
(I think the changes in variable values below are a similar case)
/lgtm |
LGTM label has been added. Git tree hash: dc8d15782a2d592c1507f4b894fcfe794432c0ef
|
What this PR does / why we need it:
Fix a panel title + ensure all bot discoveryvariables and generatepatches are shown (like in other panels)
/area devtools