✨ Update to 1.4 CAPI #661
Merged
✨ Update to 1.4 CAPI #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Signed-off-by: Chris Privitere <[email protected]>
Signed-off-by: Chris Privitere <[email protected]>
Signed-off-by: Chris Privitere <[email protected]>
Signed-off-by: Chris Privitere <[email protected]>
Signed-off-by: Chris Privitere <[email protected]>
Signed-off-by: Chris Privitere <[email protected]>
Signed-off-by: Chris Privitere <[email protected]>
Signed-off-by: Chris Privitere <[email protected]>
Signed-off-by: Chris Privitere <[email protected]>
- Add missing package comments - Add missing exported function comments - also add periods to end of many comments Signed-off-by: Chris Privitere <[email protected]>
Signed-off-by: Chris Privitere <[email protected]>
Signed-off-by: Chris Privitere <[email protected]>
- remove unused functions - add new required functions - rename of one mhc remediation test Signed-off-by: Chris Privitere <[email protected]>
cprivitere
requested review from
displague
and removed request for
deitch and
detiber
Signed-off-by: Chris Privitere <[email protected]>
displague
reviewed
Oct 26, 2023
| requests: | ||
| cpu: 100m | ||
| memory: 35Mi | ||
| securityContext: |
There was a problem hiding this comment.
nice. all we need to do is connect to APIs, no privs/root needed.
displague
reviewed
Oct 26, 2023
| } | ||
|
|
||
| func (r *PacketClusterReconciler) reconcileDelete(ctx context.Context, clusterScope *scope.ClusterScope) (ctrl.Result, error) { | ||
| func (r *PacketClusterReconciler) reconcileDelete(_ context.Context, _ *scope.ClusterScope) (ctrl.Result, error) { | ||
| // Initially I created this handler to remove an elastic IP when a cluster |
There was a problem hiding this comment.
rereading this for the first time in a while.. We probably should clean up after ourselves for any resources we dynamically provisioned. We could offer preservation behaviors in a few different ways (possibly all of them):
- IP reservation tags
locked(? this wouldn't be conventional for IP reservations. Unlike devices there is no "locked" field on the EM API resource. most likely this would look like other CAPP EM tags) - CAPP configuration parameters
--no-ip-reservation-cleanup - PacketCluster configuration parameters
displague
reviewed
Oct 26, 2023
| @@ -113,7 +125,7 @@ func (p *Client) NewDevice(ctx context.Context, req CreateDeviceRequest) (*metal | |||
| stringWriter := &strings.Builder{} | |||
| userData := string(userDataRaw) | |||
| userDataValues := map[string]interface{}{ | |||
| "kubernetesVersion": pointer.StringPtrDerefOr(req.MachineScope.Machine.Spec.Version, ""), | |||
| "kubernetesVersion": ptr.Deref(req.MachineScope.Machine.Spec.Version, ""), | |||
There was a problem hiding this comment.
cool - generics
https://pkg.go.dev/k8s.io/utils/ptr#Deref
displague
approved these changes
Oct 26, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cprivitere, displague The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR tracks the changes to update to version 1.4 of the CAPI libraries.
As part of the upgrade, we're implementing a recommended change -- the addition of an explicit default security context for the controller-manager deployment.
Finally, tooling in the makefile was updated to match the versions used in the upstream cluster-api project as of v1.4.6.
Fixes #564