Skip to content

🌱 E2E: Image refactor #2570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/e2e/data/e2e_conf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,9 @@ variables:
CCM: "../../data/ccm/cloud-controller-manager.yaml"
EXP_CLUSTER_RESOURCE_SET: "true"
OPENSTACK_BASTION_IMAGE_NAME: "cirros-0.6.1-x86_64-disk"
OPENSTACK_BASTION_IMAGE_URL: https://storage.googleapis.com/artifacts.k8s-staging-capi-openstack.appspot.com/test/cirros/2022-12-05/cirros-0.6.1-x86_64-disk.img
OPENSTACK_BASTION_IMAGE_HASH: 0c839612eb3f2469420f2ccae990827f
OPENSTACK_BASTION_IMAGE_HASH_ALGORITHM: "md5"
OPENSTACK_BASTION_MACHINE_FLAVOR: "m1.tiny"
OPENSTACK_BASTION_MACHINE_FLAVOR_ALT: "m1.tiny.alt"
OPENSTACK_CLOUD: "capo-e2e"
Expand All @@ -184,6 +187,7 @@ variables:
OPENSTACK_FAILURE_DOMAIN: "testaz1"
OPENSTACK_FAILURE_DOMAIN_ALT: "testaz2"
OPENSTACK_IMAGE_NAME: "ubuntu-2404-kube-v1.31.2"
OPENSTACK_IMAGE_URL: https://storage.googleapis.com/artifacts.k8s-staging-capi-openstack.appspot.com/test/ubuntu/2024-11-21/ubuntu-2404-kube-v1.31.2.img
OPENSTACK_IMAGE_NAME_UPGRADE_FROM: "ubuntu-2204-kube-v1.30.1"
OPENSTACK_NODE_MACHINE_FLAVOR: "m1.small"
OPENSTACK_SSH_KEY_NAME: "cluster-api-provider-openstack-sigs-k8s-io"
Expand All @@ -198,8 +202,10 @@ variables:
EXP_KUBEADM_BOOTSTRAP_FORMAT_IGNITION: "true"
# The Flatcar image produced by the image-builder
OPENSTACK_FLATCAR_IMAGE_NAME: "flatcar-stable-4152.2.0-kube-v1.31.2"
OPENSTACK_FLATCAR_IMAGE_URL: "https://storage.googleapis.com/artifacts.k8s-staging-capi-openstack.appspot.com/test/flatcar/flatcar-stable-4152.2.0-kube-v1.31.2.img"
# A plain Flatcar from the Flatcar releases server
FLATCAR_IMAGE_NAME: "flatcar_production_openstack_image"
FLATCAR_IMAGE_URL: https://stable.release.flatcar-linux.net/amd64-usr/current/flatcar_production_openstack_image.img

intervals:
conformance/wait-control-plane: ["30m", "10s"]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,18 @@
---
apiVersion: openstack.k-orc.cloud/v1alpha1
kind: Image
metadata:
name: node-image
spec:
import:
filter:
name: ${OPENSTACK_IMAGE_NAME}
managementPolicy: unmanaged
resource:
name: ${OPENSTACK_IMAGE_NAME}
content:
containerFormat: bare
diskFormat: qcow2
download:
url: ${OPENSTACK_IMAGE_URL}
managementPolicy: managed
managedOptions:
onDelete: detach
cloudCredentialsRef:
secretName: ${CLUSTER_NAME}-cloud-config
cloudName: ${OPENSTACK_CLOUD}
Expand All @@ -17,10 +22,19 @@ kind: Image
metadata:
name: bastion-image
spec:
import:
filter:
name: ${OPENSTACK_BASTION_IMAGE_NAME}
managementPolicy: unmanaged
resource:
name: ${OPENSTACK_BASTION_IMAGE_NAME}
content:
containerFormat: bare
diskFormat: qcow2
download:
url: ${OPENSTACK_BASTION_IMAGE_URL}
hash:
algorithm: ${OPENSTACK_BASTION_IMAGE_HASH_ALGORITHM}
value: ${OPENSTACK_BASTION_IMAGE_HASH}
managementPolicy: managed
managedOptions:
onDelete: detach
cloudCredentialsRef:
secretName: ${CLUSTER_NAME}-cloud-config
cloudName: ${OPENSTACK_CLOUD}
cloudName: ${OPENSTACK_CLOUD}
34 changes: 24 additions & 10 deletions test/e2e/data/kustomize/common-patches/images/images.yaml
Original file line number Diff line number Diff line change
@@ -1,13 +1,18 @@
---
apiVersion: openstack.k-orc.cloud/v1alpha1
kind: Image
metadata:
name: node-image
spec:
import:
filter:
name: ${OPENSTACK_IMAGE_NAME}
managementPolicy: unmanaged
resource:
name: ${OPENSTACK_IMAGE_NAME}
content:
containerFormat: bare
diskFormat: qcow2
download:
url: ${OPENSTACK_IMAGE_URL}
managementPolicy: managed
managedOptions:
onDelete: detach
cloudCredentialsRef:
secretName: ${CLUSTER_NAME}-cloud-config
cloudName: ${OPENSTACK_CLOUD}
Expand All @@ -17,10 +22,19 @@ kind: Image
metadata:
name: bastion-image
spec:
import:
filter:
name: ${OPENSTACK_BASTION_IMAGE_NAME}
managementPolicy: unmanaged
resource:
name: ${OPENSTACK_BASTION_IMAGE_NAME}
content:
containerFormat: bare
diskFormat: qcow2
download:
url: ${OPENSTACK_BASTION_IMAGE_URL}
hash:
algorithm: ${OPENSTACK_BASTION_IMAGE_HASH_ALGORITHM}
value: ${OPENSTACK_BASTION_IMAGE_HASH}
managementPolicy: managed
managedOptions:
onDelete: detach
cloudCredentialsRef:
secretName: ${CLUSTER_NAME}-cloud-config
cloudName: ${OPENSTACK_CLOUD}
cloudName: ${OPENSTACK_CLOUD}
6 changes: 4 additions & 2 deletions test/e2e/data/kustomize/flatcar-sysext/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
---
resources:
- ../../../../../kustomize/v1beta1/flatcar-sysext

Expand All @@ -17,5 +16,8 @@ patches:
name: node-image
patch: |-
- op: replace
path: /spec/import/filter/name
path: /spec/resource/name
value: ${FLATCAR_IMAGE_NAME}
- op: replace
path: /spec/resource/content/download/url
value: ${FLATCAR_IMAGE_URL}
5 changes: 4 additions & 1 deletion test/e2e/data/kustomize/flatcar/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,8 @@ patches:
name: node-image
patch: |-
- op: replace
path: /spec/import/filter/name
path: /spec/resource/name
value: ${OPENSTACK_FLATCAR_IMAGE_NAME}
- op: replace
path: /spec/resource/content/download/url
value: ${OPENSTACK_FLATCAR_IMAGE_URL}
1 change: 1 addition & 0 deletions test/e2e/data/kustomize/k8s-upgrade/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- ../default
- upgrade-from-images.yaml
- upgrade-from-template.yaml
- upgrade-to-template.yaml

Expand Down
25 changes: 25 additions & 0 deletions test/e2e/data/kustomize/k8s-upgrade/upgrade-from-images.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
apiVersion: openstack.k-orc.cloud/v1alpha1
kind: Image
metadata:
name: node-image-upgrade-from
spec:
import:
filter:
name: ${OPENSTACK_IMAGE_NAME_UPGRADE_FROM}
managementPolicy: unmanaged
cloudCredentialsRef:
secretName: ${CLUSTER_NAME}-cloud-config
cloudName: ${OPENSTACK_CLOUD}
---
apiVersion: openstack.k-orc.cloud/v1alpha1
kind: Image
metadata:
name: bastion-image
spec:
import:
filter:
name: ${OPENSTACK_BASTION_IMAGE_NAME}
managementPolicy: unmanaged
cloudCredentialsRef:
secretName: ${CLUSTER_NAME}-cloud-config
cloudName: ${OPENSTACK_CLOUD}
4 changes: 2 additions & 2 deletions test/e2e/shared/cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ func setupBootstrapCluster(config *clusterctl.E2EConfig, scheme *runtime.Scheme,
}

// initBootstrapCluster uses kind to create a cluster.
func initBootstrapCluster(e2eCtx *E2EContext) {
clusterctl.InitManagementClusterAndWatchControllerLogs(context.TODO(), clusterctl.InitManagementClusterAndWatchControllerLogsInput{
func initBootstrapCluster(ctx context.Context, e2eCtx *E2EContext) {
clusterctl.InitManagementClusterAndWatchControllerLogs(ctx, clusterctl.InitManagementClusterAndWatchControllerLogsInput{
ClusterProxy: e2eCtx.Environment.BootstrapClusterProxy,
ClusterctlConfigPath: e2eCtx.Environment.ClusterctlConfigPath,
InfrastructureProviders: e2eCtx.E2EConfig.InfrastructureProviders(),
Expand Down
Loading