Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Downgrade kustomize version to v5.3.0 #698

Merged

Conversation

furkatgofurov7
Copy link
Member

What this PR does / why we need it:
This is another attempt to fix the post-cluster-api-operator-push-images job with

make release-manifests
make[2]: Entering directory '/workspace'
CGO_ENABLED=0 GOBIN=/workspace/hack/tools/bin ./scripts/go_install.sh sigs.k8s.io/kustomize/kustomize/v5 kustomize v5.6.0
go: downloading sigs.k8s.io/kustomize/kustomize/v5 v5.6.0
go: sigs.k8s.io/kustomize/kustomize/[email protected] (in sigs.k8s.io/kustomize/kustomize/[email protected]): go.mod:3: invalid go version '1.22.7': must match format 1.23
make[2]: *** [Makefile:204: /workspace/hack/tools/bin/kustomize-v5.6.0] Error 1
make[2]: Leaving directory '/workspace'
make[1]: *** [Makefile:390: staging-manifests] Error 2
make[1]: Leaving directory '/workspace'
make: *** [Makefile:494: release-staging] Error 2

failures. The current version of kustomize: v5.6.0 used in the operator repo, sets go version to 1.22.7 in kustomize repo go.mod files which is the exact version seen in the failure logs whereas the version before upgrade: v5.3.0 sets it to 1.20. Please note the versioning difference, where the first specifies the patch version (x.y.Z) whereas the latter (x.y) does not.

Based on the above assumption and the fact that the failures started appearing when the bump was introduced, this PR assumes it might fix the CI failures.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 29, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 29, 2025
Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for kubernetes-sigs-cluster-api-operator ready!

Name Link
🔨 Latest commit 5031c9b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-operator/deploys/6799f275b4952b000864f0e4
😎 Deploy Preview https://deploy-preview-698--kubernetes-sigs-cluster-api-operator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 377eaa5479f9b98d550980209754ba12fc3319c7

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Danil-Grigorev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2025
@k8s-ci-robot k8s-ci-robot merged commit 3126cfa into kubernetes-sigs:main Jan 29, 2025
14 checks passed
@furkatgofurov7 furkatgofurov7 deleted the downgrade-kustomize-version branch January 29, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants