Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Use go version without the patch number in go.mod files #696

Merged

Conversation

furkatgofurov7
Copy link
Member

@furkatgofurov7 furkatgofurov7 commented Jan 28, 2025

What this PR does / why we need it:
Looks like we need to avoid using go version with patch number included in the go.mod files

go: downloading sigs.k8s.io/kustomize/kustomize/v5 v5.6.0
go: sigs.k8s.io/kustomize/kustomize/[email protected] (in sigs.k8s.io/kustomize/kustomize/[email protected]): go.mod:3: invalid go version '1.22.7': must match format 1.23
make[2]: *** [Makefile:204: /workspace/hack/tools/bin/kustomize-v5.6.0] Error 1

Similar issue was reported in siderolabs/conform#251 and suggestion was to remove patch number from the version.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Unfortunately, when running locally the same target (make release-manifests) it passes and there is no way to test it other then merging and watching the job in https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/post-cluster-api-operator-push-images

@k8s-ci-robot k8s-ci-robot requested review from damdo and Fedosin January 28, 2025 16:06
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 28, 2025
Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for kubernetes-sigs-cluster-api-operator ready!

Name Link
🔨 Latest commit 61802e2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-operator/deploys/679900692453690008ea231f
😎 Deploy Preview https://deploy-preview-696--kubernetes-sigs-cluster-api-operator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@furkatgofurov7 furkatgofurov7 changed the title 🌱 Use go version specify without the patch number in go.mod 🌱 Use go version without the patch number in go.mod files Jan 28, 2025
@Danil-Grigorev
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7ea82642750f04ec0e506febeeb539a9ad5e7d13

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Danil-Grigorev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit 2d96223 into kubernetes-sigs:main Jan 28, 2025
18 checks passed
@furkatgofurov7 furkatgofurov7 deleted the use-goversion-without-patch branch January 29, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants