🐛 Fix helm chart e2e tests: MatchYAML to Equal

[rgeraskin]

What this PR does

In this PR, I’ve reverted MatchYAML to Equal, fixed all the broken tests. Also, I discovered and fixed a bug in the core provider specification condition.

Why we need it:

While working on PR #688, I’ve observed that a significant number of Helm chart e2e tests are false positives. This is because the generated YAML files in the test/e2e/resources directory do not accurately reflect the expected results from the test cases.

I believe this issue arises because MatchYAML is being used instead of Equal (#549). MatchYAML only compares the first YAML document within a file, as demonstrated in a quick example.

package main_test

import (
	"testing"

	. "github.com/onsi/ginkgo/v2"
	. "github.com/onsi/gomega"
)

func TestGomega(t *testing.T) {
	RegisterFailHandler(Fail)
	RunSpecs(t, "Gomega Suite")
}

var _ = Describe("MatchYAML compares only the first document", func() {
	It("equals", func() {
		yaml1 := `---
hello: world
---
actually: do not care about this document
`
		yaml2 := `---
hello: world
---
even if it is not a valid yaml
`
		Expect(yaml1).To(MatchYAML(yaml2))
	})
})

[k8s-ci-robot]

Hi @rgeraskin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!

Name	Link
🔨 Latest commit	1914631
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-operator/deploys/67982cb798478d000812e337
😎 Deploy Preview	https://deploy-preview-692--kubernetes-sigs-cluster-api-operator.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[furkatgofurov7]

/ok-to-test

[Danil-Grigorev]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 1899a0c3b5d3fff8743bc39489ed1cd27f835b2a

[furkatgofurov7]

Thank you!

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furkatgofurov7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [furkatgofurov7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rgeraskin]

Thanks for the fast review 🙂