Fix no_proxy reset in configuration.py #2459

daezaa · 2025-09-30T18:18:28Z

What type of PR is this?

/kind bug

What this PR does / why we need it:

Currently, self.no_proxy is explicitly reset to None after being populated from environment variables (NO_PROXY or no_proxy). This effectively discards the loaded values and prevents no_proxy from being respected when configuring the client.

This commit removes the redundant assignment to None, ensuring that the no_proxy environment variable is preserved and proxy bypass settings are applied as expected.

Which issue(s) this PR fixes:

No issue has been opened yet. Let me know if needed.
Fixes #

Special notes for your reviewer:

The change is small but corrects behavior that currently nullifies no_proxy support.
Please confirm whether a regression test should be added for this.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

This commit removes the redundant assignment to `None`, ensuring that the `no_proxy` environment variable is preserved and proxy bypass settings are applied as expected.

linux-foundation-easycla · 2025-09-30T18:18:35Z

The committers listed above are authorized under a signed CLA.

✅ login: daezaa / name: Daesik Choi (59032da, 7e0a769)

k8s-ci-robot · 2025-09-30T18:18:37Z

Welcome @daezaa!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

afshin-paydar · 2025-10-05T07:56:39Z

lgtm 👍

roycaihw · 2025-10-09T20:36:52Z

kubernetes/client/configuration.py

        if os.getenv("no_proxy"): self.no_proxy = os.getenv("no_proxy")
        """Proxy URL
        """
-        self.no_proxy = None


The change LGTM
This file is generated by openapi-generator. We also need to update the hotfix script to keep the patch: https://github.com/kubernetes-client/python/blob/master/scripts/insert_proxy_config.sh

@roycaihw Thanks for the input. The script looks fine to me and no need changes but if it was executed on v33.1.0,

python/scripts/insert_proxy_config.sh

Lines 49 to 76 in 5f6cdb2

if [ -z "$NO_PROXY_LINE" ]; then

# self.no_proxy = None is not present → insert full block after self.proxy = None

BLOCK+="${INDENT}# Load proxy from environment variables (if set)\n"

BLOCK+="${INDENT}if os.getenv(\"HTTPS_PROXY\"): self.proxy = os.getenv(\"HTTPS_PROXY\")\n"

BLOCK+="${INDENT}if os.getenv(\"https_proxy\"): self.proxy = os.getenv(\"https_proxy\")\n"

BLOCK+="${INDENT}if os.getenv(\"HTTP_PROXY\"): self.proxy = os.getenv(\"HTTP_PROXY\")\n"

BLOCK+="${INDENT}if os.getenv(\"http_proxy\"): self.proxy = os.getenv(\"http_proxy\")\n"

BLOCK+="${INDENT}self.no_proxy = None\n"

BLOCK+="${INDENT}# Load no_proxy from environment variables (if set)\n"

BLOCK+="${INDENT}if os.getenv(\"NO_PROXY\"): self.no_proxy = os.getenv(\"NO_PROXY\")\n"

BLOCK+="${INDENT}if os.getenv(\"no_proxy\"): self.no_proxy = os.getenv(\"no_proxy\")"

sed -i "${PROXY_LINE}a $BLOCK" "$CONFIG_FILE"

echo "Inserted full proxy + no_proxy block after 'self.proxy = None'."

else

# self.no_proxy = None exists → insert only env logic after that

BLOCK+="${INDENT}# Load proxy from environment variables (if set)\n"

BLOCK+="${INDENT}if os.getenv(\"HTTPS_PROXY\"): self.proxy = os.getenv(\"HTTPS_PROXY\")\n"

BLOCK+="${INDENT}if os.getenv(\"https_proxy\"): self.proxy = os.getenv(\"https_proxy\")\n"

BLOCK+="${INDENT}if os.getenv(\"HTTP_PROXY\"): self.proxy = os.getenv(\"HTTP_PROXY\")\n"

BLOCK+="${INDENT}if os.getenv(\"http_proxy\"): self.proxy = os.getenv(\"http_proxy\")\n"

BLOCK+="${INDENT}# Load no_proxy from environment variables (if set)\n"

BLOCK+="${INDENT}if os.getenv(\"NO_PROXY\"): self.no_proxy = os.getenv(\"NO_PROXY\")\n"

BLOCK+="${INDENT}if os.getenv(\"no_proxy\"): self.no_proxy = os.getenv(\"no_proxy\")"

sed -i "${NO_PROXY_LINE}a $BLOCK" "$CONFIG_FILE"

echo "Inserted environment block after 'self.no_proxy = None'."

fi

the else block should've ran so that there would be no duplicates of self.no_proxy = None. However, somehow, if [ -z "$NO_PROXY_LINE" ]; then has ran even though there was self.no_proxy = None existed.

Nevertheless, I am revising the PR with the result of executing instert_proxy_config.sh script on v33.1.0 tag.
Please re-review

the script is not handling deleting the self.no_proxy = None when it appends the block to self.proxy section

something like the following is needed

BLOCK="" NOPROXY_BLOCK="" if [ -z "$NO_PROXY_LINE" ]; then # self.no_proxy = None is not present → insert full block after self.proxy = None BLOCK+="${INDENT}# Load proxy from environment variables (if set)\n" BLOCK+="${INDENT}if os.getenv(\"HTTPS_PROXY\"): self.proxy = os.getenv(\"HTTPS_PROXY\")\n" BLOCK+="${INDENT}if os.getenv(\"https_proxy\"): self.proxy = os.getenv(\"https_proxy\")\n" BLOCK+="${INDENT}if os.getenv(\"HTTP_PROXY\"): self.proxy = os.getenv(\"HTTP_PROXY\")\n" BLOCK+="${INDENT}if os.getenv(\"http_proxy\"): self.proxy = os.getenv(\"http_proxy\")\n" sed -i "${PROXY_LINE}a $BLOCK" "$CONFIG_FILE" NOPROXY_BLOCK+="${INDENT}# Load no_proxy from environment variables (if set)\n" NOPROXY_BLOCK+="${INDENT}if os.getenv(\"NO_PROXY\"): self.no_proxy = os.getenv(\"NO_PROXY\")\n" NOPROXY_BLOCK+="${INDENT}if os.getenv(\"no_proxy\"): self.no_proxy = os.getenv(\"no_proxy\")" sed -i "${NO_PROXY_LINE}a $NOPROXY_BLOCK" "$CONFIG_FILE" echo "Inserted proxy block after 'self.proxy = None'. and no_proxy block after 'self.no_proxy = None'." else

@roccotigger

NO_PROXY_LINE=$(grep -n "^[[:space:]]*self\.no_proxy[[:space:]]*=[[:space:]]*None" "$CONFIG_FILE" | cut -d: -f1) # If self.no_proxy = None is not present if [ -z "$NO_PROXY_LINE" ]; then ...

From your suggestion.. If NO_PROXY_LINE is empty, I don't think sed -i "${NO_PROXY_LINE}a $NOPROXY_BLOCK" "$CONFIG_FILE" is valid and you would need to put self.no_proxy = None

I honestly don't see a problem with existing script.. If you try this script on v33.1.0, it works fine and the result of it is the pull request I made...
Please let me know if I am mistaken.

TEST DONE

Procedure:

Clone and check out to v33.1.0

$ git clone https://github.com/kubernetes-client/python.git $ cd python $ git checkout v33.1.0 $ git branch * (HEAD detached at v33.1.0) master

Download insert_proxy_config.sh in master branch

$ cd scripts $ curl -fsSL -o insert_proxy_config.sh https://raw.githubusercontent.com/kubernetes-client/python/master/scripts/insert_proxy_config.sh $ chmod +x insert_proxy_config.sh

Run script and validate configuration.py (Make sure no redundant self.no_proxy = None)

$ ./insert_proxy_config.sh Inserted 'import os' after existing imports in <my_directory>/python/scripts/../kubernetes/client/configuration.py. Inserted environment block after 'self.no_proxy = None'. $ cat ../kubernetes/client/configuration.py | grep -A 20 " self.proxy = None" self.proxy = None """Proxy URL """ self.no_proxy = None # Load proxy from environment variables (if set) if os.getenv("HTTPS_PROXY"): self.proxy = os.getenv("HTTPS_PROXY") if os.getenv("https_proxy"): self.proxy = os.getenv("https_proxy") if os.getenv("HTTP_PROXY"): self.proxy = os.getenv("HTTP_PROXY") if os.getenv("http_proxy"): self.proxy = os.getenv("http_proxy") # Load no_proxy from environment variables (if set) if os.getenv("NO_PROXY"): self.no_proxy = os.getenv("NO_PROXY") if os.getenv("no_proxy"): self.no_proxy = os.getenv("no_proxy") """bypass proxy for host in the no_proxy list. """ self.proxy_headers = None """Proxy headers """ self.safe_chars_for_path_param = '' """Safe chars for path_param """ self.retries = None $ cat ../kubernetes/client/configuration.py | grep "self.no_proxy = None" self.no_proxy = None

Re run script for the future release

$ ./insert_proxy_config.sh 'import os' already present; no changes made. Proxy environment code already present; no changes made. $ cat ../kubernetes/client/configuration.py | grep -A 20 " self.proxy = None" self.proxy = None """Proxy URL """ self.no_proxy = None # Load proxy from environment variables (if set) if os.getenv("HTTPS_PROXY"): self.proxy = os.getenv("HTTPS_PROXY") if os.getenv("https_proxy"): self.proxy = os.getenv("https_proxy") if os.getenv("HTTP_PROXY"): self.proxy = os.getenv("HTTP_PROXY") if os.getenv("http_proxy"): self.proxy = os.getenv("http_proxy") # Load no_proxy from environment variables (if set) if os.getenv("NO_PROXY"): self.no_proxy = os.getenv("NO_PROXY") if os.getenv("no_proxy"): self.no_proxy = os.getenv("no_proxy") """bypass proxy for host in the no_proxy list. """ self.proxy_headers = None """Proxy headers """ self.safe_chars_for_path_param = '' """Safe chars for path_param """ self.retries = None $ cat ../kubernetes/client/configuration.py | grep "self.no_proxy = None" self.no_proxy = None

cc : @roycaihw @yliaog

I was unable to run scripts/update-client.sh. The closest I could come was to use the v33.1.0 version.

@daezaa Your analysis is correct that the script will operate correctly without changes.

How did the wrong changes make it into v34.1.0?

How to ensure they are corrected in the next released version?

How did the wrong changes make it into v34.1.0?

Well, that is my question too. :(

How to ensure they are corrected in the next released version?

Tried re-running the script and the file was conserved.

$ ./insert_proxy_config.sh 'import os' already present; no changes made. Proxy environment code already present; no changes made.

daniram94 · 2025-10-26T13:09:02Z

LGTM

daezaa · 2025-10-28T01:06:33Z

@yliaog @roycaihw Can you please review this PR?

yliaog · 2025-10-28T01:14:06Z

i think you want to change the script, rather than the generated file, otherwise, the generated file will be overridden during next release.

daezaa · 2025-10-28T01:30:35Z

i think you want to change the script, rather than the generated file, otherwise, the generated file will be overridden during next release.

@yliaog #2459 (comment) Please check my comment here. The script itself is looking good.

daezaa · 2025-11-04T16:31:41Z

Can we get this reviewed please?

Problem with v33.1.0 is, it doesn't honour HTTP_PROXY/HTTPS_PROXY env var from the client.
v33.1.0...v34.1.0#diff-977bedbaf9339b25749bc96a24266c1fa3e99ab521a835562fe84b2ab87b7001L160

Problem with v34.1.0 is, configuration.proxy from below could now be turned on by above change but configuration.no_proxy is ALWAYS ''. Therefore should_by_pass NO_PROXY wouldn't work as expected.

python/kubernetes/client/rest.py

Line 90 in fe1a331

    
           if configuration.proxy and not should_bypass_proxies(configuration.host, no_proxy=configuration.no_proxy or ''):

yliaog · 2025-11-06T19:24:45Z

@daezaa please check #2459 (comment)

daezaa · 2025-11-10T18:17:31Z

#2459 (comment) Comment updated.. thanks

k8s-ci-robot · 2025-11-11T06:18:22Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: daezaa, roccotigger
Once this PR has been reviewed and has the lgtm label, please assign roycaihw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Fix no_proxy reset in configuration.py

7e0a769

This commit removes the redundant assignment to `None`, ensuring that the `no_proxy` environment variable is preserved and proxy bypass settings are applied as expected.

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Sep 30, 2025

k8s-ci-robot requested review from roycaihw and yliaog September 30, 2025 18:18

feuerrot mentioned this pull request Oct 6, 2025

NO_PROXY/no_proxy env vars not working as expected, as of 34.1.0 #2460

Open

roycaihw reviewed Oct 9, 2025

View reviewed changes

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 9, 2025

daezaa force-pushed the master branch from 7c95a4f to 7e0a769 Compare October 9, 2025 21:34

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 9, 2025

daezaa force-pushed the master branch from 7fe5e16 to 99b8e7d Compare October 9, 2025 21:40

update configuration.py - rerunning insert_proxy_config.sh on v33.1.0

59032da

daezaa force-pushed the master branch from 99b8e7d to 59032da Compare October 9, 2025 21:41

daezaa requested a review from roycaihw October 9, 2025 21:43

daezaa requested a review from roccotigger November 10, 2025 18:17

roccotigger approved these changes Nov 11, 2025

View reviewed changes

	if [ -z "$NO_PROXY_LINE" ]; then
	# self.no_proxy = None is not present → insert full block after self.proxy = None
	BLOCK+="${INDENT}# Load proxy from environment variables (if set)\n"
	BLOCK+="${INDENT}if os.getenv(\"HTTPS_PROXY\"): self.proxy = os.getenv(\"HTTPS_PROXY\")\n"
	BLOCK+="${INDENT}if os.getenv(\"https_proxy\"): self.proxy = os.getenv(\"https_proxy\")\n"
	BLOCK+="${INDENT}if os.getenv(\"HTTP_PROXY\"): self.proxy = os.getenv(\"HTTP_PROXY\")\n"
	BLOCK+="${INDENT}if os.getenv(\"http_proxy\"): self.proxy = os.getenv(\"http_proxy\")\n"
	BLOCK+="${INDENT}self.no_proxy = None\n"
	BLOCK+="${INDENT}# Load no_proxy from environment variables (if set)\n"
	BLOCK+="${INDENT}if os.getenv(\"NO_PROXY\"): self.no_proxy = os.getenv(\"NO_PROXY\")\n"
	BLOCK+="${INDENT}if os.getenv(\"no_proxy\"): self.no_proxy = os.getenv(\"no_proxy\")"

	sed -i "${PROXY_LINE}a $BLOCK" "$CONFIG_FILE"
	echo "Inserted full proxy + no_proxy block after 'self.proxy = None'."
	else
	# self.no_proxy = None exists → insert only env logic after that
	BLOCK+="${INDENT}# Load proxy from environment variables (if set)\n"
	BLOCK+="${INDENT}if os.getenv(\"HTTPS_PROXY\"): self.proxy = os.getenv(\"HTTPS_PROXY\")\n"
	BLOCK+="${INDENT}if os.getenv(\"https_proxy\"): self.proxy = os.getenv(\"https_proxy\")\n"
	BLOCK+="${INDENT}if os.getenv(\"HTTP_PROXY\"): self.proxy = os.getenv(\"HTTP_PROXY\")\n"
	BLOCK+="${INDENT}if os.getenv(\"http_proxy\"): self.proxy = os.getenv(\"http_proxy\")\n"
	BLOCK+="${INDENT}# Load no_proxy from environment variables (if set)\n"
	BLOCK+="${INDENT}if os.getenv(\"NO_PROXY\"): self.no_proxy = os.getenv(\"NO_PROXY\")\n"
	BLOCK+="${INDENT}if os.getenv(\"no_proxy\"): self.no_proxy = os.getenv(\"no_proxy\")"

	sed -i "${NO_PROXY_LINE}a $BLOCK" "$CONFIG_FILE"
	echo "Inserted environment block after 'self.no_proxy = None'."
	fi

Fix no_proxy reset in configuration.py #2459

Are you sure you want to change the base?

Fix no_proxy reset in configuration.py #2459

Uh oh!

Conversation

daezaa commented Sep 30, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

linux-foundation-easycla bot commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Sep 30, 2025

Uh oh!

afshin-paydar commented Oct 5, 2025

Uh oh!

roycaihw Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

daezaa Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

roccotigger Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

daezaa Nov 10, 2025

Choose a reason for hiding this comment

Procedure:

Uh oh!

roccotigger Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

daezaa Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

daniram94 commented Oct 26, 2025

Uh oh!

daezaa commented Oct 28, 2025

Uh oh!

yliaog commented Oct 28, 2025

Uh oh!

daezaa commented Oct 28, 2025

Uh oh!

daezaa commented Nov 4, 2025

Uh oh!

yliaog commented Nov 6, 2025

Uh oh!

daezaa commented Nov 10, 2025

Uh oh!

k8s-ci-robot commented Nov 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

linux-foundation-easycla bot commented Sep 30, 2025 •

edited

Loading

daezaa Oct 9, 2025 •

edited

Loading

roccotigger Nov 5, 2025 •

edited

Loading