Skip to content

fix(object): properly serialize objects on create/replace/patch #2400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2025
Merged

fix(object): properly serialize objects on create/replace/patch #2400

merged 2 commits into from
May 2, 2025

Conversation

schrodit
Copy link
Contributor

Fixes #2396

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 29, 2025
@schrodit
Copy link
Contributor Author

/assign mstruebing

@cjihrig
Copy link
Contributor

cjihrig commented Apr 29, 2025

Can you add tests please.

@brendandburns
Copy link
Contributor

Thanks for the PR +1 for unit tests.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 30, 2025
@schrodit schrodit force-pushed the fix-serialization branch from bee74ae to caeb79d Compare April 30, 2025 15:32
@schrodit
Copy link
Contributor Author

schrodit commented Apr 30, 2025 •
edited
Loading

@cjihrig @brendandburns added a unit tests to test the correct serialization

@schrodit schrodit force-pushed the fix-serialization branch from caeb79d to 39c35d9 Compare April 30, 2025 15:33
@schrodit
Copy link
Contributor Author

/assign brendandburns

cjihrig
cjihrig approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjihrig, schrodit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2025
@k8s-ci-robot k8s-ci-robot merged commit 57dd6c0 into kubernetes-client:main May 2, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@davidgamero davidgamero Awaiting requested review from davidgamero

@mstruebing mstruebing Awaiting requested review from mstruebing

Assignees

@cjihrig cjihrig

@brendandburns brendandburns

@mstruebing mstruebing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NetworkPolicy.spec.ingress.from is not correctly serialized
5 participants
@schrodit @cjihrig @brendandburns @k8s-ci-robot @mstruebing