Skip to content

Conversation

@omrajshinde534
Copy link
Contributor

What this PR does

  • Adds missing JUnit Jupiter parameterized test dependency
  • Fixes test compilation failures across modules
  • Removes unused dependencies
  • Ensures full Maven build passes successfully

Testing

  • Ran ./mvnw clean test locally
  • All modules build successfully
  • No test failures observed

Notes

This change only updates dependency declarations and does not affect runtime behavior.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 27, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Welcome @omrajshinde534!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 27, 2025
@omrajshinde534
Copy link
Contributor Author

Hi maintainers,
CLA is signed and all modules build successfully locally.
Kindly let me know if any changes are needed.
Thanks!

@brendandburns
Copy link
Contributor

Thanks for the PR, Minor comments on formatting then LGTM

@omrajshinde534
Copy link
Contributor Author

Hi maintainers,
All review comments have been addressed:
XML formatting fixed
junit-jupiter-params version moved to the parent pom.xml
Module POMs cleaned up and now inherit versions consistently

Please let me know if anything else is needed. Thanks!

@brendandburns
Copy link
Contributor

/lgtm
/approve
/ok-to-test

Thanks for the PR!

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 8, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, omrajshinde534

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2026
@k8s-ci-robot k8s-ci-robot merged commit 0f35346 into kubernetes-client:master Jan 8, 2026
2 checks passed
@omrajshinde534
Copy link
Contributor Author

Thank you so much for the review and approval
Really appreciate the feedback and guidance throughout the process.
Glad to contribute — looking forward to contributing more in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants