Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enable GCI for golangci-lint #2540

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

tenzen-y
Copy link
Member

What this PR does / why we need it:
It's challenging to keep maintaining the dependencies group, manually. So, It would be great to add golangci-lint opt-in linter, "GCI".

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@tenzen-y
Copy link
Member Author

/assign @kubeflow/wg-training-leads @astefanutti

@tenzen-y tenzen-y changed the title chore: Enable GCI to golangci-lint chore: Enable GCI for golangci-lint Mar 18, 2025
Copy link
Contributor

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice!

Copy link
Member

@Electronic-Waste Electronic-Waste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tenzen-y Thanks for this! LGTM!

/lgtm

@tenzen-y
Copy link
Member Author

#2460 Again

=================================== FAILURES ===================================
_ TestDatasetIntegration.test_dataset_download[HuggingFace - Public dataset-huggingface-test_case0] _

response = <Response [[40](https://github.com/kubeflow/trainer/actions/runs/13925570979/job/38969057348?pr=2540#step:5:41)3]>, endpoint_name = None

    def hf_raise_for_status(response: Response, endpoint_name: Optional[str] = None) -> None:
        """
        Internal version of `response.raise_for_status()` that will refine a
        potential HTTPError. Raised exception will be an instance of `HfHubHTTPError`.
    
        This helper is meant to be the unique method to raise_for_status when making a call
        to the Hugging Face Hub.

@tenzen-y
Copy link
Member Author

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti, Electronic-Waste, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 38adf62 into kubeflow:master Mar 18, 2025
15 checks passed
@tenzen-y tenzen-y deleted the enable-gci-lint branch March 18, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants