-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cncf-hosted gha runners #2538
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Jeffrey Sica <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great that we have access to the Oracle runners 🎉
Thank you for this @jeefy!
Should we update this issue and update other repos (e.g. mpi-operator
): kubeflow/community#829 ?
cc @kubeflow/wg-training-leads @kubeflow/kubeflow-steering-committee
Yup! However there is a difference between the GitHub hosted and the CNCF
hosted runners.
Our runners are running in containers. The GitHub hosted ones run in VMs.
There can be dependency drift and unforeseen issues we'll have to work
through. Should be fun though 🙂
…On Mon, Mar 17, 2025, 14:37 Andrey Velichkevich ***@***.***> wrote:
***@***.**** commented on this pull request.
This is great that we have access to the Oracle runners 🎉
Thank you for this @jeefy <https://github.com/jeefy>!
Should we update this issue and update other repos (e.g. mpi-operator):
kubeflow/community#829 <kubeflow/community#829>
?
cc @kubeflow/wg-training-leads
<https://github.com/orgs/kubeflow/teams/wg-training-leads>
@kubeflow/kubeflow-steering-committee
<https://github.com/orgs/kubeflow/teams/kubeflow-steering-committee>
—
Reply to this email directly, view it on GitHub
<#2538 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKUO6CVJGEAHADFEVQS2HD2U4P67AVCNFSM6AAAAABZGDQZDGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMOJRG44DAMBZGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
If we move all CI jobs to CNCF hosted runner, we need to create DinD container images so that we can perform Kind cluster during CI. |
If i understand this correctly, it is only for the more expensive larger GHA runners, not the default ones provided by GitHub. So we only need to migrate workflows that benefit from larger runners or VMs. |
Yes, your understanding is correct. I indicated Trainer E2E, mostly. |
DIND is already baked into the current setup. You can do docker builds (and some other jobs already are) Need to debug why your e2e/kind cluster didn't spin up though. |
Oh, I didn't know that. Thank you for letting us know |
Description
CNCF has hosted ephemeral GitHub runners in Oracle that we're wanting projects to use rather than the GitHub hosted ones, which are now incur a cost to use.
This PR is currently a WIP to work through any tests that break or dependencies that may be missing.<3Please direct any questions to myself, @krook and @RobertKielty