-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deployment): update mysql to 5.7 and support running as nonroot #5278
Conversation
Hi @juliusvonkohout. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thank you!
In KFP standalone mode, we deploy metadata-db also on 5.7, so I believe you can rest assured it works. |
I just created gcr.io/ml-pipeline/mysql:5.7, can you use it instead? /ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
/lgtm |
Hmm, would you mind also updating pipelines/test/tag_for_hosted.sh Lines 111 to 112 in 9c10d4f
It's for KFP on GCP marketplace. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy, juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Done. All test are successful. I just had to add a fix for docker-library/mysql#186 |
/lgtm |
Thank you so much for the great contribution! |
@Bobgy sorry, but the heavy restructuring made it quite pointless to do a manual rebase of #5228
docker.io/mysql:5.7 is an official dockerhub image. So there should not be rate limits AFAIK. But you can of course create gcr.io/ml-pipeline/mysql:5.7 .
metadata-db that you want to merge with this mysql database currently uses mysql:8.0. But ml-pipeline does not work with 8.0
So you should make sure that the metadata stuff works with 5.7 or fix ml-pipeline to work with 8.0 and create gcr.io/ml-pipeline/mysql:8.0 from docker.io/mysql:8.0.
I tested that metadata-db works with mysql:5.7 and all pods are running, but i could not really test the functionallity because https://github.com/kubeflow/metadata/blob/master/sdk/python/sample/demo.ipynb seems to be broken.
Related to kubeflow/manifests#1756