Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deployment): update mysql to 5.7 and support running as nonroot #5278

Merged
merged 7 commits into from
Mar 14, 2021

Conversation

juliusvonkohout
Copy link
Member

@juliusvonkohout juliusvonkohout commented Mar 10, 2021

@Bobgy sorry, but the heavy restructuring made it quite pointless to do a manual rebase of #5228

docker.io/mysql:5.7 is an official dockerhub image. So there should not be rate limits AFAIK. But you can of course create gcr.io/ml-pipeline/mysql:5.7 .

metadata-db that you want to merge with this mysql database currently uses mysql:8.0. But ml-pipeline does not work with 8.0

[julius@localhost ~]$ kubectl -n kubeflow logs ml-pipeline-7c56db5db9-ts547 -c ml-pipeline-api-server 
I0310 18:49:55.490470       8 client_manager.go:134] Initializing client manager
I0310 18:49:55.490564       8 config.go:50] Config DBConfig.ExtraParams not specified, skipping

(Error 1046: No database selected) 
[2021-03-10 18:49:55]  

(Error 1046: No database selected) 
[2021-03-10 18:49:55]  

(Error 1046: No database selected) 
[2021-03-10 18:49:55]  

(Error 1046: No database selected) 
[2021-03-10 18:49:55]  

(Error 1046: No database selected) 
[2021-03-10 18:49:55]  

(Error 1046: No database selected) 
[2021-03-10 18:49:55]  

(Error 1046: No database selected) 
[2021-03-10 18:49:55]  
F0310 18:49:55.518981       8 client_manager.go:212] Failed to initialize the databases.

So you should make sure that the metadata stuff works with 5.7 or fix ml-pipeline to work with 8.0 and create gcr.io/ml-pipeline/mysql:8.0 from docker.io/mysql:8.0.

I tested that metadata-db works with mysql:5.7 and all pods are running, but i could not really test the functionallity because https://github.com/kubeflow/metadata/blob/master/sdk/python/sample/demo.ipynb seems to be broken.

Related to kubeflow/manifests#1756

@google-oss-robot
Copy link

Hi @juliusvonkohout. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Bobgy
Copy link
Contributor

Bobgy commented Mar 13, 2021

Thank you!

I tested that metadata-db works with mysql:5.7 and all pods are running, but i could not really test the functionallity because https://github.com/kubeflow/metadata/blob/master/sdk/python/sample/demo.ipynb seems to be broken.

In KFP standalone mode, we deploy metadata-db also on 5.7, so I believe you can rest assured it works.

@Bobgy Bobgy changed the title Update mysql feat(deployment): update mysql to 5.7 and support running as nonroot Mar 13, 2021
@Bobgy
Copy link
Contributor

Bobgy commented Mar 13, 2021

I just created gcr.io/ml-pipeline/mysql:5.7, can you use it instead?

/ok-to-test

Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@Bobgy
Copy link
Contributor

Bobgy commented Mar 13, 2021

/lgtm

@Bobgy
Copy link
Contributor

Bobgy commented Mar 13, 2021

Hmm, would you mind also updating

docker tag gcr.io/ml-pipeline/mysql:5.6 gcr.io/$PROJECT_ID/hosted/$COMMIT_SHA/mysql:$SEM_VER
docker tag gcr.io/ml-pipeline/mysql:5.6 gcr.io/$PROJECT_ID/hosted/$COMMIT_SHA/mysql:$MM_VER
?

It's for KFP on GCP marketplace.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout
Copy link
Member Author

Hmm, would you mind also updating

docker tag gcr.io/ml-pipeline/mysql:5.6 gcr.io/$PROJECT_ID/hosted/$COMMIT_SHA/mysql:$SEM_VER
docker tag gcr.io/ml-pipeline/mysql:5.6 gcr.io/$PROJECT_ID/hosted/$COMMIT_SHA/mysql:$MM_VER

?

It's for KFP on GCP marketplace.

Done. All test are successful. I just had to add a fix for docker-library/mysql#186

@juliusvonkohout juliusvonkohout requested a review from Bobgy March 14, 2021 10:50
@Bobgy
Copy link
Contributor

Bobgy commented Mar 14, 2021

/lgtm

@google-oss-robot google-oss-robot merged commit 3cdb1d9 into kubeflow:master Mar 14, 2021
@Bobgy
Copy link
Contributor

Bobgy commented Mar 14, 2021

Thank you so much for the great contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants