helm: add Kubeflow Notebooks chart#3525
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome to the Kubeflow Community Distribution Repository Thanks for opening your first PR. Your contribution means a lot to the Kubeflow community. Before making more PRs: Community Resources:
Thanks again for helping to improve Kubeflow. |
There was a problem hiding this comment.
Pull request overview
Adds a co-located Helm wrapper chart for Kubeflow Notebooks v1 under applications/notebooks-v1/helm, and wires it into the existing Helm/Kustomize render-parity comparison and synchronization workflow so future upstream refreshes also regenerate the chart payload.
Changes:
- Introduce
kubeflow-notebooksHelm wrapper chart (static Kustomize-parity “platform” scenario). - Extend Helm/Kustomize comparison scripts to include the new
kubeflow-notebookscomponent/scenario. - Update the Notebooks v1 synchronization script and CI workflow to keep the chart’s
appVersionand rendered platform template refreshed (and to install Helm v4.2.2 for the comparison job).
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
applications/notebooks-v1/helm/Chart.yaml |
New chart metadata for kubeflow-notebooks. |
applications/notebooks-v1/helm/README.md |
Installation and parity-comparison instructions for the new chart. |
applications/notebooks-v1/helm/values.yaml |
Default values, including the scenario switch. |
applications/notebooks-v1/helm/ci/values-platform.yaml |
CI fixture values for the platform scenario. |
applications/notebooks-v1/helm/templates/platform.yaml |
Generated static template containing the platform render payload. |
applications/notebooks-v1/helm/templates/validate.yaml |
Scenario validation guardrail for supported values. |
tests/helm_kustomize_compare.sh |
Adds kubeflow-notebooks wiring (chart path, kustomize overlay, values, namespace). |
tests/helm_kustomize_compare_all.sh |
Adds kubeflow-notebooks to the “all components” scenario matrix and help text. |
tests/helm_kustomize_compare.py |
Allows kubeflow-notebooks as a recognized component in the comparison tool. |
scripts/synchronize-notebooks-v1-manifests.sh |
Extends sync to also update chart appVersion and regenerate templates/platform.yaml. |
.github/workflows/helm-kustomize-comparison.yml |
Triggers on Notebooks changes and installs Helm v4.2.2 for parity checks. |
| elif component == "hub": | ||
| return set() # No extra resources in Helm for Model Registry | ||
| elif component == "kserve-models-web-app": | ||
| return set() | ||
| elif component == "kubeflow-notebooks": | ||
| return set() | ||
| else: |
There was a problem hiding this comment.
Fixed by preserving Notebooks app labels.
cea8d26 to
4a0882a
Compare
| update_readme "$MANIFESTS_DIRECTORY" "$source_text" "$destination_text" | ||
| } | ||
| TARGET_DIR="applications/notebooks-v1/upstream/" | ||
| TARGET_DIRECTORY="applications/notebooks-v1/upstream/" |
5c7e6d9 to
d2148f8
Compare
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
4925c00 to
1447480
Compare
Summary of Changes
Adds the Kubeflow Notebooks v1 Helm wrapper chart as a co-located application chart under
applications/notebooks-v1/helm.This PR keeps the first reviewable slice focused on Kustomize parity for the customer-facing Notebooks platform install path. It retains the
platformscenario, which maps toapplications/notebooks-v1/overlays/istio, and does not introduce standalone, split-component, or broad customization modes in this initial chart PR.The PR also updates Helm/Kustomize comparison wiring to the new chart path, uses Helm 4 in the comparison workflow, and extends
scripts/synchronize-notebooks-v1-manifests.shso future Notebooks upstream syncs also refresh the Helm chartappVersionand regenerated static platform template.The chart is placed under
applications/notebooks-v1/helmbecause Notebooks v1 is an official application component, and this is the application-side equivalent of placing common wrappers undercommon/<component>/helm. The sync script ownsapplications/notebooks-v1/upstream, while the Helm chart lives as a sibling underapplications/notebooks-v1/helm.Dependencies
Conceptually follows the foundation, wrapper, and Dashboard chart PRs for runtime installation order:
Render parity validation for this PR is self-contained.
Related Issues
Part of the Project 5 Helm chart work.
Contributor Checklist
Validation
Also verified with temporary Helm
v4.2.2: