-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: helm action in componentplan controller #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #248 +/- ##
==========================================
- Coverage 17.61% 17.60% -0.02%
==========================================
Files 34 35 +1
Lines 3452 3562 +110
==========================================
+ Hits 608 627 +19
- Misses 2811 2898 +87
- Partials 33 37 +4
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Abirdcfly
force-pushed
the
cplcontroller
branch
23 times, most recently
from
August 17, 2023 05:54
10b5110
to
4fc5597
Compare
github-actions
bot
requested review from
0xff-dev,
bjwswang,
Lanture1064 and
nkwangleiGIT
August 17, 2023 05:58
3 tasks
Abirdcfly
force-pushed
the
cplcontroller
branch
2 times, most recently
from
August 18, 2023 09:43
27740df
to
a46b11e
Compare
bjwswang
previously approved these changes
Aug 18, 2023
Abirdcfly
force-pushed
the
cplcontroller
branch
from
August 18, 2023 09:58
a46b11e
to
f86d062
Compare
bjwswang
force-pushed
the
cplcontroller
branch
from
August 21, 2023 01:44
f86d062
to
ce1e968
Compare
Abirdcfly
force-pushed
the
cplcontroller
branch
from
August 22, 2023 03:42
ce1e968
to
071271e
Compare
Abirdcfly
force-pushed
the
cplcontroller
branch
2 times, most recently
from
August 22, 2023 14:13
dbf417e
to
e134f2b
Compare
bjwswang
approved these changes
Aug 23, 2023
Abirdcfly
force-pushed
the
cplcontroller
branch
from
August 23, 2023 01:02
e134f2b
to
1515c75
Compare
0xff-dev
approved these changes
Aug 23, 2023
Signed-off-by: Abirdcfly <[email protected]>
Signed-off-by: Abirdcfly <[email protected]>
Signed-off-by: Abirdcfly <[email protected]>
Signed-off-by: Abirdcfly <[email protected]>
Signed-off-by: Abirdcfly <[email protected]>
Abirdcfly
force-pushed
the
cplcontroller
branch
from
August 23, 2023 02:02
1515c75
to
09b2056
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it
There are 5 commit:
Post-sequence tests will be added in the new pr.
Which issue(s) this PR fixes
For #194
Special notes for your reviewer