Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔥 More test cases #194

Closed
0xff-dev opened this issue Aug 2, 2023 · 4 comments
Closed

🔥 More test cases #194

0xff-dev opened this issue Aug 2, 2023 · 4 comments
Assignees
@Abirdcfly @dayuy @0xff-dev @bjwswang @zqq454224016 @Henry-Gao-2004
Labels
difficulty-medium Normal amount of changes, no design detail adjustments DO NOT CLOSE priority-medium

Comments

@0xff-dev
Copy link
Collaborator

0xff-dev commented Aug 2, 2023 •
edited by bjwswang
Loading

codecov

Right now, our code has very low test coverage 🌝. We need more and richer test cases to improve code coverage.
Need everyone's help.

We can start by improving the test coverage of the code in the api/v1alpha1 and pkg directories. And then improve the operator's test coverage.

Track latest codeco stas at https://app.codecov.io/gh/kubebb/core
image
@0xff-dev 0xff-dev added priority-medium difficulty-medium Normal amount of changes, no design detail adjustments labels Aug 2, 2023
@bjwswang bjwswang pinned this issue Aug 2, 2023
@Abirdcfly
Copy link
Member

For the controllers folder it can be a bit more complicated, there are some references to be found at https://github.com/operator-framework/operator-sdk/blob/master/testdata/go/v3/memcached-operator/controllers/memcached_controller_test.go

@Henry-Gao-2004
Copy link
Contributor

I will also try to add more test cases!

@Henry-Gao-2004 Henry-Gao-2004 mentioned this issue Aug 2, 2023
Merged
This was referenced Aug 2, 2023
Merged
Merged
Merged
This was referenced Aug 3, 2023
Merged
Merged
Closed
Merged
@0xff-dev 0xff-dev mentioned this issue Aug 6, 2023
Merged
@Henry-Gao-2004 Henry-Gao-2004 mentioned this issue Aug 7, 2023
Merged
@Abirdcfly Abirdcfly mentioned this issue Aug 7, 2023
Merged
@bjwswang
Copy link
Collaborator

bjwswang commented Aug 14, 2023 •
edited
Loading

image

Still lots of work has to be done here!

@Abirdcfly
Copy link
Member

I will try to add some test for controller this week.

@Henry-Gao-2004 Henry-Gao-2004 mentioned this issue Aug 14, 2023
Merged
@Abirdcfly Abirdcfly mentioned this issue Aug 15, 2023
Merged
@Henry-Gao-2004 Henry-Gao-2004 mentioned this issue Aug 18, 2023
Closed
@0xff-dev 0xff-dev mentioned this issue Aug 26, 2023
Merged
@0xff-dev 0xff-dev mentioned this issue Sep 11, 2023
Merged
This was referenced Sep 14, 2023
Merged
Merged
This was referenced Oct 8, 2023
Merged
Merged
@0xff-dev 0xff-dev closed this as completed Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Abirdcfly Abirdcfly

@dayuy dayuy

@0xff-dev 0xff-dev

@bjwswang bjwswang

@zqq454224016 zqq454224016

@Henry-Gao-2004 Henry-Gao-2004

Labels
difficulty-medium Normal amount of changes, no design detail adjustments DO NOT CLOSE priority-medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Abirdcfly @dayuy @0xff-dev @bjwswang @zqq454224016 @Henry-Gao-2004