Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add var disable_hetzner_ccm #1575

Merged
merged 5 commits into from
Dec 23, 2024
Merged

Conversation

pat-s
Copy link
Contributor

@pat-s pat-s commented Nov 30, 2024

This is needed to allow deploying HCCM standalone which is required when one wants to include robot servers, which is only possible when deploying HCCM using the helm chart due to some helm chart magic.

@pat-s pat-s marked this pull request as ready for review November 30, 2024 16:13
Copy link
Collaborator

@mysticaltech mysticaltech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @pat-s

@mysticaltech mysticaltech merged commit 09f9c0d into kube-hetzner:master Dec 23, 2024
3 checks passed
@mysticaltech
Copy link
Collaborator

Hey @pat-s, FYI, had to reverse this because it broke the deployment with the following error:

module.kube-hetzner.null_resource.kustomization (remote-exec): Connected!
module.kube-hetzner.null_resource.kustomization: Still creating... [20s elapsed]
module.kube-hetzner.null_resource.kustomization (remote-exec): + sed -i 's/^- |[0-9]\+$/- |/g' /var/post_install/kustomization.yaml
module.kube-hetzner.null_resource.kustomization (remote-exec): + timeout 360 bash
module.kube-hetzner.null_resource.kustomization (remote-exec): + kubectl apply -k /var/post_install
module.kube-hetzner.null_resource.kustomization (remote-exec): error: accumulating resources: accumulation err='merging resources from 'https://github.com/hetznercloud/hcloud-cloud-controller-manager/releases/download/v1.21.0/ccm-networks.yaml': may not add resource with an already registered id: Deployment.v1.apps/hcloud-cloud-controller-manager.kube-system': evalsymlink failure on '/tmp/kustomize-3994297745/releases/download/v1.21.0/ccm-networks.yaml' : lstat /tmp/kustomize-3994297745/releases: no such file or directory
module.kube-hetzner.null_resource.agents["0-0-agent-small"]: Still creating... [1m0s elapsed]

If you want to resubmit, please test it well and please explain better how it works.

@pat-s
Copy link
Contributor Author

pat-s commented Dec 24, 2024

Strange. I am using it since some time in my fork in exactly this variant without issues.

@pat-s
Copy link
Contributor Author

pat-s commented Jan 2, 2025

@mysticaltech I just tried again and was unable to reproduce the failure. I'll open another PR and maybe others can give it a try, too. Or maybe you could add how you tested it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants