fix: make gimme.sh fail if download URL results in error#1
Open
davidxia wants to merge 1 commit intoksync:masterfrom
Open
fix: make gimme.sh fail if download URL results in error#1davidxia wants to merge 1 commit intoksync:masterfrom
davidxia wants to merge 1 commit intoksync:masterfrom
Conversation
like 404.
I'm on Apple silicon Mac M1 where `uname -m` returns `arm64`
and `${DOWNLOAD_URL}` is
https://github.com/ksync/ksync/releases/download/0.4.7-hotfix/ksync_darwin_arm64.
## Before
```
❯ curl https://ksync.github.io/gimme-that/gimme.sh | bash
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 2758 100 2758 0 0 34565 0 --:--:-- --:--:-- --:--:-- 36289
Checking GitHub for the latest release of ksync
Found release tag: 0.4.7-hotfix
Downloading ksync_darwin_arm64
No previous install found. Installing ksync to /usr/local/bin/ksync
❯ which ksync
/usr/local/bin/ksync
❯ ksync --help
/usr/local/bin/ksync: line 1: Not: command not found
❯ cat /usr/local/bin/ksync
Not found
```
## After
```
❯ ~/Downloads/./gimme.sh
Checking GitHub for the latest release of ksync
Found release tag: 0.4.7-hotfix
Downloading ksync_darwin_arm64
No previous install found. Installing ksync to /usr/local/bin/ksync
curl: (22) The requested URL returned error: 404
```
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
like 404.
I'm on Apple silicon Mac M1 where
uname -mreturnsarm64and${DOWNLOAD_URL}ishttps://github.com/ksync/ksync/releases/download/0.4.7-hotfix/ksync_darwin_arm64.
Before
After