Skip to content

Commit

Permalink
CONTRIBUTING: strengthen the assertion that we want tests
Browse files Browse the repository at this point in the history
Signed-off-by: Ricardo Signes <[email protected]>
  • Loading branch information
rjbs committed Mar 15, 2023
1 parent ef6a684 commit 2beda9f
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@ copying the style of the surrounding code.
## The Tests

You should run the tests. Submitting a change that breaks existing tests isn't
good for anybody! Adding new tests to assert that your changes work is even
better, and should be the goal.
good for anybody! If your pull request changes the code but doesn't add a
test, you should explain why. "Code changes add tests" is the default
assumption.

There are two kinds of tests:

Expand Down

0 comments on commit 2beda9f

Please sign in to comment.