Modify run_with_result() to return Result<(), Box<dyn std::error::Error>> #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #78
This eliminates the
ActionResult
type and movesActionError
into theerror.rs
file alongsideFlagError
. To allow it to be returned inBox<>
values,ActionError
is a struct with an associated enumActionErrorKind
. This is different fromFlagError
, which is an enum, and for consistency we may want to renameFlagError
toFlagErrorKind
and add a newFlagError
struct that is similar toActionError
.This is a breaking change from
v2.2.0
but only in the types returned byrun_with_result
and the functions of typeActionWithResult
. I think it is worth making this change for consistency with general Rust best practices, as described in Recoverable Errors with Result.