Skip to content

Trace logging#72

Closed
WT-MM wants to merge 5 commits intomasterfrom
logging
Closed

Trace logging#72
WT-MM wants to merge 5 commits intomasterfrom
logging

Conversation

@WT-MM
Copy link
Copy Markdown
Contributor

@WT-MM WT-MM commented May 12, 2025

No description provided.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 13, 2025

CLA assistant check
All committers have signed the CLA.

@jingxiangmo jingxiangmo requested a review from Copilot May 13, 2025 06:21
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances trace logging in the Supervisor module to provide more visibility into feedback and command processing. Key changes include:

  • Adding new trace and debug log entries to record feedback processing, callback execution, command dispatching, and actuator feedback requests.
  • Reformatting a frame callback for improved readability.
  • Bumping the package version in Cargo.toml to 0.3.7.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
actuator/robstride/src/supervisor.rs Added logging statements for feedback, command dispatch, and callbacks
Cargo.toml Updated package version from 0.3.6 to 0.3.7
Comments suppressed due to low confidence (2)

actuator/robstride/src/supervisor.rs:763

  • [nitpick] The event name 'MITCommandSent' is unclear and may cause confusion; please consider renaming it to a more descriptive identifier.
debug!(event = "MITCommandSent", motor_id = id, cmd = ?cmd, "Supervisor sending command to actuator");

actuator/robstride/src/supervisor.rs:137

  • [nitpick] Verify consistency of logging levels across similar events to ensure that the verbosity in log messages is aligned with the intended diagnostic outcomes.
trace!(event = "FeedbackProcessed", motor_id = feedback.motor_id, feedback_details = ?feedback, "Actuator state updated with feedback");

@codekansas codekansas closed this Sep 15, 2025
@codekansas codekansas deleted the logging branch September 15, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants