Tests: pkg dynamiccontroller: increases test coverage #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dhairya Majmudar <[email protected]>
a-hilaly
reviewed
Mar 19, 2025
| expected: true, | ||
| }, | ||
| { | ||
| name: "one unsynced informer", |
There was a problem hiding this comment.
can we have some test cases for one synced informer, many synced informers and many sync informers and many unsynced informers ?
There was a problem hiding this comment.
@a-hilaly I've added the suggested changes and also simplified them a bit but the tests cases for one synced informer and many synced informers are failing.
It seems to be like some bug with actual function, can you pls. confirm once.
Signed-off-by: Dhairya Majmudar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pkg/dynamiccontroller/dynamiccontroller_test.gofileio/ioutilpackage toioScreenShots
cc: @a-hilaly