-
Notifications
You must be signed in to change notification settings - Fork 179
Add E2E test framework and 2 simple tests #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
barney-s
wants to merge
6
commits into
kro-run:main
Choose a base branch
from
barney-s:e2e
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0c197e7
to
0047f82
Compare
Please look at https://github.com/kubernetes-sigs/e2e-framework and see if we can use it. |
…-run#279 for the make deploy-kind target
…is is expected to fail due to: kro-run#272. So not invoking it as part of GH workflow
- test step for testing kro-run#293. skip it for now till that PR is merged - test for verifying kro-run#299 - Using secrets with stringData - test for verifying kro-run#300 - using secret.metadata.resourceVersion in deployment
/assign @matthchr - Would you please take a look at this. |
@justinsb - Can you please take a look at this PR. Please comment on the approach being used for e2e testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
example of successful run: https://github.com/kro-run/kro/actions/runs/13269233780/job/37044442598?pr=290
Test output