Fix mypy error in images_aoai_quickstart.py - add null check for result.data#13
Closed
Fix mypy error in images_aoai_quickstart.py - add null check for result.data#13
Conversation
…lt.data Co-authored-by: kristapratico <31998003+kristapratico@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix mypy error in samples/images_aoai_quickstart.py
Fix mypy error in images_aoai_quickstart.py - add null check for result.data
Jun 4, 2025
|
Hi @Copilot. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a mypy type checking error in
samples/images_aoai_quickstart.pywhereresult.datawas being accessed without checking forNone.Problem
The mypy error occurred at line 65 with the message:
This happened because
result.datahas typeOptional[list[Image]], meaning it could potentially beNone, but the code was directly indexing into it:Solution
Added a null check before accessing the list elements:
This change:
result.datais notNoneand contains at least one element before indexingNoneif the data is missing, which works seamlessly with the existingif image_url:checkTesting
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
http://168.63.129.16:80/machine//usr/bin/python3 -u bin/WALinuxAgent-2.13.1.1-py3.9.egg -collect-logs(http block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.