Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Handle middleware errors #45

Closed
wants to merge 1 commit into from
Closed

feat: Handle middleware errors #45

wants to merge 1 commit into from

Conversation

shivarm
Copy link

@shivarm shivarm commented Nov 3, 2023

Summary

The error handling middleware allows us to separate our error logic and send responses accordingly. The next() method we discussed in middleware takes us to next middleware/route handler. For error handling, we have the next(err) function.

Description

Explain in detail what this PR is all about. This should include the problem you're solving, the approach taken, and any technical details that reviewers need to know.

Images

Include any relevant images or diagrams that can help reviewers visualize the changes, if applicable

Issue(s) Addressed #46

Enter the issue number of the bug(s) that this PR fixes

  • Template should be strictly Closes <issue_number>

Prerequisites

Copy link

vercel bot commented Nov 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wanderlust ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2023 1:11am
wanderlust-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2023 1:11am

@krishnaacharyaa
Copy link
Owner

@shivam-sharma7 Thank you for raising PR,
Can I respectfully grab your attention to the first guideline of contributing
"Claiming an Issue: Before you start working on an issue, make sure it's assigned to you. We do this to avoid overlapping efforts and to ensure your hard work doesn't go to waste. Please avoid raising a PR for an issue assigned to someone else."
And it is assigned to DSAghicha, he seems working on this, and has almost finished working on this.

Can you kindly look into any other available issues, or create a own get it assigned to you and then work on it ... That would be really nice....

@krishnaacharyaa
Copy link
Owner

I meant, This seems to solve the issue of #1 which is already assigned....

I suggest you to please create issue is not already available and then get it assigned then raise the relevant PR. Thank you for your efforts, I'm just trying to make sure no one's efforts is gone waste, kindly co-operate 🙂

@krishnaacharyaa
Copy link
Owner

krishnaacharyaa commented Nov 5, 2023

Hi @shivam-sharma7, this directly is related to #1 and implements the solution which is already proposed in this, kindly pick other issue as previously clearly specified couple of times.
Thank you

#46 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants