-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: #28 long time to load bg image #34
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @krishnaacharyaa on Vercel. @krishnaacharyaa first needs to authorize it. |
Hey @krishnaacharyaa ,tried to create a new pr following the given pr template, and for the previous commits , im a little new at git for now, i have tried my best to do as you mentioned but if it is still not as it should be, please inform me for the same ill try to do more research about it and create a new pr..... Thanks, any kind of feedback will be greatly appreciated |
Thank you @jjinendra3, for your sincere efforts I really appreciate the time and efforts put into storing the gif into google drive and sharing the link, which was not expected, thank you for the efforts. Just some points to share if you already didn't know,
Some observations
|
To answer the git part |
Just one thing to keep in mind you can use this as reference dont take my word for it, sometimes some part even I might have missed, feel free to let me know if any. Happy to correct myself and learn :) |
Hey @krishnaacharyaa , I wanted to take a moment to express my sincere thanks your efforts that have helped me grow and learn, not only about Git/GitHub but also about the MERN stack. The guidance and knowledge you've shared is something I genuinely appreciate. Now, I plan to create a new pull request and will try incorporate all the changes you've mentioned. Thank you once again for your guidance and the opportunity to contribute to this project. |
@jjinendra3 Thank you for your kind words 😇 Always happy to share and I am glad to hear that it is greatly helping you :) |
Summary
Changed the jpeg bg image to webp file eliminating 5-6 seconds and crucial resources that was being taken to load a bg image.
Description
Hosted the converted jpeg to webp file on imgbb to save on the overall build site keeping in mind that we will never the chanage the bg image, the home page now loads much faster and looks better.
Images
OLD AND NEW GIFS
Issue(s) Addressed
Enter the issue number of the bug(s) that this PR fixes
Review Checklist
Please make sure to go through this checklist before submitting your review.
tag: Issue Title
fix
,feat
,docs
,chore
,refactor
feat: Added responsive design for the home page
file-name.ts
notfileName.ts