Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Created a new header-layout file to segregate out header code. #124

Merged
merged 7 commits into from
Apr 2, 2024

Conversation

0xmohitsen
Copy link
Contributor

@0xmohitsen 0xmohitsen commented Apr 2, 2024

Summary

This PR introduces modular approach by separating header-code in a new 'header-layout' file rather than keeping into a single file (home-page).

Description

This PR isolates the header-related code from the home-page file and moves it into a new header-layout file, along with all imported modules. It then integrates this header-layout as a component within the home-page file.

Images

Include any relevant images or diagrams that can help reviewers visualize the changes, if applicable

Issue(s) Addressed

Prerequisites

Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wanderlust ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 7:15am
wanderlust-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 7:15am

Copy link
Owner

@krishnaacharyaa krishnaacharyaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run npm run format in the frontend folder and commit

@0xmohitsen
Copy link
Contributor Author

Please run npm run format in the frontend folder and commit

Done.

Copy link
Owner

@krishnaacharyaa krishnaacharyaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Mohitsen11 For the quick response :)

@krishnaacharyaa krishnaacharyaa merged commit 13960bf into krishnaacharyaa:main Apr 2, 2024
3 checks passed
@0xmohitsen
Copy link
Contributor Author

Thank you @Mohitsen11 For the quick response :)

Thank you, @krishnaacharyaa, for guiding and helping me to learn best practices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants