Save covers directly into covers dir #306
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of saving the pixbuf of the new cover into a temporary file and then copy into covers dir, save it directly to there. Without this, a lot of temporary files are created on import, which remain on the system even after the application is closed.
Checking for file extension does not ensure that the image file can be actually opened. Check if it can be loaded into a pixbuf, and convert it if necessary.
Decoding/encoding errors sometimes raise an OSError or ValueError.
convert_cover() now always return a temporary file, which needs to be removed after the cover is saved. Without this, these files would remain on the system until reboot. Also remove the downloaded temporary files after save.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of saving the pixbuf of the new cover into a temporary file and then copy into covers dir, save it directly to there. Without this, a lot of temporary files are created on import, which remain on the system even after the application is closed.