Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update cli-utils to v0.27.0 #2581

Closed
wants to merge 1 commit into from

Conversation

karlkfi
Copy link
Contributor

@karlkfi karlkfi commented Nov 12, 2021

This is a test to make sure kpt can adopt the latest cli-utils. Version v0.27.0 is not out yet, but we can release it soon if all goes well here.

Major changes:

  • No default reconcile timeout (wait until cancelled)
  • No default prune/delete timeout (wait until cancelled)
  • Always wait for reconciliation after apply/prune/delete (previously only waited if there were dependencies, causing more than one apply task)
  • Send WaitEvent for every object
  • Added deletion prevention annotations
  • Context cancel/timeout now sends an error and event
  • Update K8s libs to v0.22.2
  • Update kyaml to v0.12.0
  • Printers moved from cmd to pkg

This will most notably change the output and behavior of kpt live apply/status/destroy.

@karlkfi
Copy link
Contributor Author

karlkfi commented Nov 12, 2021

Note, I ran into several bugs with the Makefile while trying to build this.

  • go-licenses install is broken
  • when updated, go-licenses modifies a bunch of files on master, like yamls
  • golangci-lint errors on thirdparty files

@karlkfi
Copy link
Contributor Author

karlkfi commented Nov 12, 2021

License issues fixed by #2583

@@ -151,7 +151,7 @@ func TestPathManifestReader_Read(t *testing.T) {
"cr.yaml": cr,
},
namespace: "test-namespace",
expectedErrMsg: "unknown resource types: Custom.custom.io",
expectedErrMsg: "unknown resource types: custom.io/v1, Kind=Custom",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karlkfi
Copy link
Contributor Author

karlkfi commented Nov 12, 2021

Found a bug with apply-time-mutation: kubernetes-sigs/cli-utils#481 (probably pre-dates this update tho)

@karlkfi
Copy link
Contributor Author

karlkfi commented Jan 4, 2022

Duplicate of #2616

@karlkfi karlkfi closed this Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant