Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix init image at creation #759

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rjodinchr
Copy link
Contributor

We need to create the cvk_command_image_init with a valid context. Otherwise we can have a race condition between the destruction of queue and commands being deleted in the executor thread.

@rjodinchr
Copy link
Contributor Author

switftshader artifact needs to be refreshed

@kpet
Copy link
Owner

kpet commented Jan 24, 2025

Kicked off https://github.com/kpet/clvk/actions/runs/12951700691

@rjodinchr rjodinchr force-pushed the pr/fix-init-image-at-creation branch from 8908894 to 085672d Compare January 24, 2025 15:12
@rjodinchr
Copy link
Contributor Author

Can you re-trigger the failing bot? It's the first time I'm seeing that error. I wonder if it happens just very rarely. I'm not able to reproduce on my machine. That may be something we just want to filter in the test to avoid flakyness I guess

@rjodinchr rjodinchr force-pushed the pr/fix-init-image-at-creation branch 2 times, most recently from 5e3541a to a9683d9 Compare February 25, 2025 06:45
@rjodinchr rjodinchr force-pushed the pr/fix-init-image-at-creation branch from a9683d9 to 9ef9dc1 Compare March 18, 2025 14:51
@rjodinchr
Copy link
Contributor Author

In fact, the bug was much simpler than what I was thinking. It's just about not forcing the deletion of the queue.

@rjodinchr
Copy link
Contributor Author

CI should be fixed with #771

@rjodinchr
Copy link
Contributor Author

Using a cvk_command_queue_holder would be better looking, but we would go back to the headers issue: #735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants