Refactor error handling for streaming chat flow #117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #113
Error
type fromStreamingChatLanguageModelReply
and its usage. Currently theerror
was being emitted twice. Once as an exception, and once as data. We should avoid emitting an event twice, since it only occurs once. It's possible for the user to manually transform the exception into a value usingcatch { emit(...) }
as demonstrated in my other PR. Alternatively we can keepStreamingChatLanguageModelReply.Error
but not re-emit again onclose(throwable)
. This is a design decision that needs to be made. I don't have a strong preference to be honest, one or the other is fine. You can go back and forth by usingcatch
orthrow
.