Skip to content

[Fix] Potentially access the wrong key when there are multiple parameter groups#465

Merged
kozistr merged 3 commits intomainfrom
fix/looksam
Dec 20, 2025
Merged

[Fix] Potentially access the wrong key when there are multiple parameter groups#465
kozistr merged 3 commits intomainfrom
fix/looksam

Conversation

@kozistr
Copy link
Copy Markdown
Owner

@kozistr kozistr commented Dec 20, 2025

Problem (Why?)

Fixes #442

Solution (What/How?)

  • add group idx too

Other changes (bug fixes, small refactors)

N/A

Notes

N/A

Checklist

  • Make sure to run make format before commit
  • My code adheres to the style guidelines of this project (make check shows no errors)
  • Both new and existing unit tests pass successfully on my local environment by running make test
  • I have made the necessary changes to the documentation

@kozistr kozistr self-assigned this Dec 20, 2025
@kozistr kozistr added bug Something isn't working and removed size/S labels Dec 20, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation optimizer about optimizer labels Dec 20, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (1375069) to head (d464866).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #465   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          120       120           
  Lines        11028     11028           
=========================================
  Hits         11028     11028           
Flag Coverage Δ
3.10 100.00% <100.00%> (?)
3.11 100.00% <100.00%> (?)
3.12 100.00% <100.00%> (ø)
3.13 100.00% <100.00%> (?)
3.14 100.00% <100.00%> (?)
3.8 99.99% <100.00%> (ø)
3.9 99.99% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kozistr kozistr merged commit a37468b into main Dec 20, 2025
20 checks passed
@kozistr kozistr deleted the fix/looksam branch December 20, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation optimizer about optimizer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LookSAM bug

1 participant