ability to parse extra parameters to mysql jdbc#374
Open
mprokopov wants to merge 2 commits intokorma:release_0.4.3from
Open
ability to parse extra parameters to mysql jdbc#374mprokopov wants to merge 2 commits intokorma:release_0.4.3from
mprokopov wants to merge 2 commits intokorma:release_0.4.3from
Conversation
|
Is there anyone looking into this ? |
Contributor
|
In general this approach seems fine, but it needs tests before we'll be able to consider merging it. |
venantius
reviewed
Feb 27, 2018
| @@ -1,4 +1,4 @@ | |||
| (defproject korma "0.4.3" | |||
Contributor
There was a problem hiding this comment.
Don't change the project name.
|
though we can specify extra parameters in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows specify extra parameters for mysql jdbc driver in map under key :extra
example:
this appends "?useLegacyDatetimeCode&serverTimezone=UTC&useSSL=false" to subname