-
Notifications
You must be signed in to change notification settings - Fork 49
Add Support to Kool Cloud Deploy to ARM #524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for deploying to ARM platforms by updating the Docker build command and related configurations. Key changes include:
- Updating BuildPushImageForDeploy to accept a new 'platform' parameter for Docker.
- Adding a new Platform flag with a default value to the cloud deploy command.
- Including additional indirect dependencies in go.mod.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| services/cloud/build.go | Updated BuildPushImageForDeploy to use a platform parameter. |
| go.mod | Added new indirect dependencies. |
| commands/cloud_deploy.go | Added a Platform flag and updated the deploy command invocation. |
Comments suppressed due to low confidence (3)
services/cloud/build.go:18
- The updated function signature now requires a 'platform' parameter. Confirm that all function invocations have been updated accordingly.
func BuildPushImageForDeploy(service string, config *DeployConfigService, deploy *api.DeployCreateResponse, platform string) (err error) {
commands/cloud_deploy.go:56
- [nitpick] Ensure the default value 'linux/amd64' is documented in the usage instructions or README to inform users of the expected behavior.
cmd.Flags().StringVarP(&deploy.flags.Platform, "platform", "", "linux/amd64", "Platform for docker build (default: linux/amd64)")
go.mod:53
- [nitpick] Verify that the addition of this indirect dependency is required for the implementation of ARM support and is kept current.
github.com/russross/blackfriday/v2 v2.1.0 // indirect
| WwwRedirect bool // env: KOOL_DEPLOY_WWW_REDIRECT | ||
| DeployDomainExtras []string // env: KOOL_DEPLOY_DOMAIN_EXTRAS | ||
|
|
||
| Platform string // platform for docker build, e.g. linux/amd64 |
Copilot
AI
May 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider expanding the comment to document the range of acceptable platform values for clarity.
|
|
||
| require ( | ||
| github.com/Azure/go-ansiterm v0.0.0-20230124172434-306776ec8161 // indirect | ||
| github.com/cpuguy83/go-md2man/v2 v2.0.2 // indirect |
Copilot
AI
May 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Review whether this indirect dependency is necessary for the new ARM support to avoid unnecessary maintenance overhead.
| github.com/cpuguy83/go-md2man/v2 v2.0.2 // indirect |
No description provided.