Skip to content

Conversation

@dbpolito
Copy link
Member

No description provided.

@dbpolito dbpolito requested review from Copilot and fabriciojs May 22, 2025 16:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for deploying to ARM platforms by updating the Docker build command and related configurations. Key changes include:

  • Updating BuildPushImageForDeploy to accept a new 'platform' parameter for Docker.
  • Adding a new Platform flag with a default value to the cloud deploy command.
  • Including additional indirect dependencies in go.mod.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
services/cloud/build.go Updated BuildPushImageForDeploy to use a platform parameter.
go.mod Added new indirect dependencies.
commands/cloud_deploy.go Added a Platform flag and updated the deploy command invocation.
Comments suppressed due to low confidence (3)

services/cloud/build.go:18

  • The updated function signature now requires a 'platform' parameter. Confirm that all function invocations have been updated accordingly.
func BuildPushImageForDeploy(service string, config *DeployConfigService, deploy *api.DeployCreateResponse, platform string) (err error) {

commands/cloud_deploy.go:56

  • [nitpick] Ensure the default value 'linux/amd64' is documented in the usage instructions or README to inform users of the expected behavior.
cmd.Flags().StringVarP(&deploy.flags.Platform, "platform", "", "linux/amd64", "Platform for docker build (default: linux/amd64)")

go.mod:53

  • [nitpick] Verify that the addition of this indirect dependency is required for the implementation of ARM support and is kept current.
github.com/russross/blackfriday/v2 v2.1.0 // indirect

WwwRedirect bool // env: KOOL_DEPLOY_WWW_REDIRECT
DeployDomainExtras []string // env: KOOL_DEPLOY_DOMAIN_EXTRAS

Platform string // platform for docker build, e.g. linux/amd64
Copy link

Copilot AI May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider expanding the comment to document the range of acceptable platform values for clarity.

Copilot uses AI. Check for mistakes.

require (
github.com/Azure/go-ansiterm v0.0.0-20230124172434-306776ec8161 // indirect
github.com/cpuguy83/go-md2man/v2 v2.0.2 // indirect
Copy link

Copilot AI May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Review whether this indirect dependency is necessary for the new ARM support to avoid unnecessary maintenance overhead.

Suggested change
github.com/cpuguy83/go-md2man/v2 v2.0.2 // indirect

Copilot uses AI. Check for mistakes.
@fabriciojs fabriciojs merged commit 498c1a3 into main May 22, 2025
8 checks passed
@fabriciojs fabriciojs deleted the kool_cloud_deploy_platform branch May 22, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants