fix(clawpatch): address daily finding#234
Closed
michiosw wants to merge 1 commit into
Closed
Conversation
Greptile SummaryThis PR updates the root workspace test command to include the Go race detector. The main change is:
Confidence Score: 5/5This looks safe to merge.
Reviews (1): Last reviewed commit: "fix(clawpatch): address daily finding" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Where We Are
The root workspace test script skipped the documented
go test -race ./...check. A change could passpnpm testwhile still missing the race detector run that the README tells contributors to use.Where We Want To Go
pnpm testshould enforce the same race detector check the repo documents, so the default local test path catches data races before merge.How do we get there
Update the root
testscript inpackage.jsonto rungo test -race ./...beforego vet ./.... Verification:go test ./...,go vet ./...,npm exec --yes --package pnpm@10.0.0 -- pnpm install --frozen-lockfile,npm exec --yes --package pnpm@10.0.0 -- pnpm --dir web/guard-dashboard typecheck, andgit diff --checkall passed in the temp checkout.