Allow to top align the cover in manga info view #816
Conversation
Reviewer's Guide by SourceryThis pull request introduces a new user preference to control whether the cover image in the manga info view is vertically centered or aligned to the top. The preference is enabled by default, centering the cover image. A new switch has been added to the appearance settings screen to toggle this preference. Updated class diagram for UiPreferencesclassDiagram
class UiPreferences {
-preferenceStore: PreferenceStore
+usePanoramaCoverAlways(): Flow<Boolean>
+usePanoramaCoverMangaInfo(): Flow<Boolean>
+verticallyCenterCover(): Flow<Boolean>
}
note for UiPreferences "Added verticallyCenterCover() method"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @LetrixZ, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request introduces a new user preference to control the vertical alignment of the cover image in the manga info view. By default, the cover is vertically centered, but this change allows users to align it to the top instead. This is achieved by adding a new switch preference in the settings and modifying the MangaInfoHeader composable to respect this preference when rendering the cover image.
Highlights
- New Preference: A new boolean preference
verticallyCenterCoveris added toUiPreferencesto control the vertical alignment of the cover image. - UI Modification: The
MangaInfoHeadercomposable is updated to use theverticallyCenterCoverpreference to determine the vertical alignment of the cover image. - Settings Screen Update: A new switch preference is added to the SettingsAppearanceScreen to allow users to toggle the vertical alignment of the cover image.
- Localization: New string resources are added for the title and summary of the new preference.
Changelog
Click here to see the changelog
- app/src/main/java/eu/kanade/domain/ui/UiPreferences.kt
- Added
verticallyCenterCover()function to store and retrieve the vertical cover alignment preference (line 74).
- Added
- app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt
- Collected the
verticallyCenterCoverpreference as a state (line 130). - Passed the
verticallyCenterCoverstate to theMangaAndSourceTitlesSmallcomposable (line 188). - Modified the
MangaAndSourceTitlesSmallcomposable to use theverticallyCenterCoverpreference to set theverticalAlignmentof theRowcontaining the cover and titles (line 566). - Modified the
MangaCover.Panoramacomposable to use theverticallyCenterCoverpreference to set theverticalAlignment(line 574). - Modified the
MangaCover.Squarecomposable to use theverticallyCenterCoverpreference to set theverticalAlignment(line 596).
- Collected the
- app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsAppearanceScreen.kt
- Added a new
SwitchPreferencefor theverticallyCenterCoverpreference (lines 207-211).
- Added a new
- i18n-kmk/src/commonMain/moko-resources/base/strings.xml
- Added new string resources for
pref_vertically_center_coverandpref_vertically_center_cover_summary(lines 41-42).
- Added new string resources for
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A cover's alignment, a subtle art,
Centered or top, a brand new start.
With preference set, the choice is yours,
To customize views and open new doors.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a new preference to control the vertical alignment of the manga cover image in the manga info view. The implementation appears straightforward and well-integrated into the existing settings and UI components. The addition of localized strings for the new preference is also a good practice.
Merge Readiness
The code changes seem well-implemented and the new feature is a useful addition. I recommend merging this pull request after addressing the identified medium severity issue. I am unable to directly approve the pull request, and other reviewers should review and approve this code before merging.
app/src/main/java/eu/kanade/presentation/manga/components/MangaInfoHeader.kt
Outdated
Show resolved
Hide resolved
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @LetrixZ - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a margin to the top of the cover when it's aligned to the top, so it doesn't touch the edge of the screen.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
I don't really prefer the top alignment but it won't hurt to add this I guess. But could you revert the settings to Top align or some thing, so that the setting can be default Off? |
LetrixZ
changed the title
Done |
Adds an option to align the cover to the top in the manga info view.
Images
Summary by Sourcery
Add a user preference to control vertical alignment of manga cover images in the manga info view
New Features:
Enhancements:
Documentation: